Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redelete connector dockerfiles #31228

Closed
wants to merge 1 commit into from
Closed

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Oct 10, 2023

connectors shouldn't (?) need explicit dockerfiles anymore. #30743 attempted to delete them, but accidentally re-added some in a merge commit (0e946d2). This PR just re-deletes those dockerfiles.

find airbyte-integrations/connectors -name Dockerfile still shows a lot of dockerfiles, and it's not clear to me why they need to remain. In the interest of making forward progress, I'm just deleting the ones that we tried to delete earlier.

@edgao edgao requested a review from a team as a code owner October 10, 2023 19:03
@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Oct 10, 2023 7:03pm

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

source-github test report (commit 8776bbbae6) - ❌

⏲️ Total pipeline duration: 42.64s

Step Result
Connector package install
Build source-github docker image for platform(s) linux/x86_64
Code format checks
Validate metadata for source-github
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-github test

@airbyte-oss-build-runner
Copy link
Collaborator

source-google-ads test report (commit 8776bbbae6) - ❌

⏲️ Total pipeline duration: 48.79s

Step Result
Connector package install
Build source-google-ads docker image for platform(s) linux/x86_64
Code format checks
Validate metadata for source-google-ads
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@airbyte-oss-build-runner
Copy link
Collaborator

source-mixpanel test report (commit 8776bbbae6) - ❌

⏲️ Total pipeline duration: 30.87s

Step Result
Connector package install
Build source-mixpanel docker image for platform(s) linux/x86_64
Code format checks
Validate metadata for source-mixpanel
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mixpanel test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-pinecone test report (commit 8776bbbae6) - ❌

⏲️ Total pipeline duration: 01mn29s

Step Result
Connector package install
Build destination-pinecone docker image for platform(s) linux/x86_64
Code format checks
Validate metadata for destination-pinecone
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pinecone test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-qdrant test report (commit 8776bbbae6) - ❌

⏲️ Total pipeline duration: 01mn44s

Step Result
Connector package install
Build destination-qdrant docker image for platform(s) linux/x86_64
Code format checks
Validate metadata for destination-qdrant
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-qdrant test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-chroma test report (commit 8776bbbae6) - ❌

⏲️ Total pipeline duration: 01mn45s

Step Result
Connector package install
Build destination-chroma docker image for platform(s) linux/x86_64
Code format checks
Validate metadata for destination-chroma
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-chroma test

@airbyte-oss-build-runner
Copy link
Collaborator

source-google-analytics-data-api test report (commit 8776bbbae6) - ❌

⏲️ Total pipeline duration: 38.86s

Step Result
Connector package install
Build source-google-analytics-data-api docker image for platform(s) linux/x86_64
Code format checks
Validate metadata for source-google-analytics-data-api
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-data-api test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-milvus test report (commit 8776bbbae6) - ❌

⏲️ Total pipeline duration: 01mn17s

Step Result
Connector package install
Build destination-milvus docker image for platform(s) linux/x86_64
Code format checks
Validate metadata for destination-milvus
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-milvus test

Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python connector Dockerfile can't be deleted unless the connector declares the baseImage version it's using (eg).
Removing python connector dockerfile is part of this epic. I'm actively working on it. I'll take care about documenting the migration process once the new build process is 💯 ready.

@edgao edgao closed this Oct 10, 2023
@edgao edgao deleted the edgao/dockerfile_deletions branch October 10, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment