Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update CI credentials docs to point to new GCP project (#30813)" #31593

Merged

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Oct 18, 2023

What

  • Reverting instructions to old google cloud project since the new one doesn't have all the secrets we expect. FYI @wennergr since you mentioned dataline-integration-testing was supposed to be deprecated.

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Oct 18, 2023 11:00pm

@girarda girarda enabled auto-merge (squash) October 18, 2023 23:01
@girarda
Copy link
Contributor Author

girarda commented Oct 18, 2023

/approve-and-merge this is a doc change waiting for CI tests?

@octavia-approvington
Copy link
Contributor

Trying to merge your PR using a bot?
Comment this on the PR:

/approve-and-merge reason="<STATE YOUR REASON HERE>"

Make sure you've reviewed the docs!

@girarda
Copy link
Contributor Author

girarda commented Oct 18, 2023

/approve-and-merge reason="this is a doc change waiting for CI tests?"

@octavia-approvington
Copy link
Contributor

Approve this
imagine the commander saying yes

@octavia-approvington octavia-approvington merged commit 1129bb0 into master Oct 18, 2023
20 checks passed
@octavia-approvington octavia-approvington deleted the revert-30813-alex/update_ci_credentials_docs branch October 18, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants