Pre-Work for adding Checkpointing #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -154,6 +154,7 @@ private static RecordWriter recordWriterFunction(final Map<String, Index> indexN | |||
| // Tools like DBT do not apply. Therefore, we need to try to write data in the most usable format | |||
| // possible that does not require alteration. | |||
| final String json = Jsons.serialize(recordStream | |||
There was a problem hiding this comment.
rename variable: records instead of recordStream
cgardens
force-pushed
the
cgardens/prepare_destination_changes
branch
from
f08ba2e
to
27559b8
Compare
Merged
davinchia
added a commit
that referenced
this pull request
May 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR handles cleaning up some stuff that has to be done before checkpointing can happening. Doing it here to avoid adding noise to the meat of the change.
AirbyteMessages instead of justAirbyteRecordMessages.RecordWriteriface operate on lists of records (instead of streams). In practice the records were represented as lists on both sides of the interface already anyway. This interface it operating on batches that are being written to the db, so they need to be able to fit into memory anyway.