Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix prework #3188

Merged
merged 5 commits into from
May 3, 2021
Merged

fix prework #3188

merged 5 commits into from
May 3, 2021

Conversation

cgardens
Copy link
Contributor

@cgardens cgardens commented May 3, 2021 •
edited

What

Fixed some things I missed in: #3163

  • I had missed updating a couple usages of the FailureTrackingConsumer.
  • Needed to BufferedStreamConsumer to pass a RecordMessage instead of AirbyteMessage to the RecordWriters.

Tests caught these problems, which is great. I just merged too soon.

@cgardens
Copy link
Contributor Author

cgardens commented May 3, 2021 •
edited by github-actions bot

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/807814836
❌ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/807814836

@cgardens
Copy link
Contributor Author

cgardens commented May 3, 2021 •
edited by github-actions bot

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/807815038
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/807815038

@cgardens
Copy link
Contributor Author

cgardens commented May 3, 2021 •
edited by github-actions bot

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/807815143
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/807815143

@cgardens
Copy link
Contributor Author

cgardens commented May 3, 2021 •
edited by github-actions bot

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/807863499
❌ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/807863499

@cgardens
Copy link
Contributor Author

cgardens commented May 3, 2021 •
edited by github-actions bot

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/807863646
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/807863646

@cgardens
Copy link
Contributor Author

cgardens commented May 3, 2021 •
edited by github-actions bot

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/807863830
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/807863830

@cgardens cgardens changed the title Cgardens/fix prework fix prework May 3, 2021
@cgardens cgardens marked this pull request as ready for review May 3, 2021 19:27
@auto-assign auto-assign bot requested review from davinchia and jrhizor May 3, 2021 19:27
@cgardens
Copy link
Contributor Author

cgardens commented May 3, 2021 •
edited by github-actions bot

/test connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/807867790
✅ connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/807867790

@cgardens
Copy link
Contributor Author

cgardens commented May 3, 2021 •
edited by github-actions bot

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/807880065
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/807880065

@cgardens cgardens merged commit c512a7e into master May 3, 2021
@cgardens cgardens deleted the cgardens/fix_prework branch May 3, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia Awaiting requested review from davinchia

@jrhizor jrhizor Awaiting requested review from jrhizor

Assignees
No one assigned
Labels
connectors/destination/bigquery connectors/destination/snowflake connectors/destinations-warehouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cgardens @karinakuz