Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ source-zendesk-chat + source-auth0: update the base image #31643

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 20, 2023

What

I originally tried out the base image migration with source-auth0 and source-zendesk-chat.
Now that we have released a new base image version (1.1.0) we want these connector to use it.

How

airbyte-ci commands only:

 airbyte-ci connectors --name=source-auth0 --name=source-zendesk-chat upgrade_base_image
 airbyte-ci connectors --name=source-auth0 --name=source-zendesk-chat bump_version patch 31643 "Upgrade base image to airbyte/python-connector-base:1.1.0"

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 9:15am

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Oct 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@alafanechere alafanechere force-pushed the augustin/10-20-source-zendesk-chat_source-auth0_update_the_base_image branch from 0b5d439 to 6225810 Compare October 20, 2023 08:54
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 20, 2023
@alafanechere alafanechere marked this pull request as ready for review October 20, 2023 08:56
@alafanechere alafanechere changed the title source-zendesk-chat + source-auth0: update the base image ✨ source-zendesk-chat + source-auth0: update the base image Oct 20, 2023
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 20, 2023 08:57
@airbyte-oss-build-runner
Copy link
Collaborator

source-auth0 test report (commit 6225810366) - ✅

⏲️ Total pipeline duration: 01mn41s

Step Result
Build source-auth0 docker image for platform(s) linux/x86_64
Acceptance tests
Code format checks
Validate metadata for source-auth0
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-auth0 test

@airbyte-oss-build-runner
Copy link
Collaborator

source-zendesk-chat test report (commit 6225810366) - ❌

⏲️ Total pipeline duration: 02mn38s

Step Result
Build source-zendesk-chat docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-zendesk-chat
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-chat test

@bazarnov
Copy link
Collaborator

bazarnov commented Oct 20, 2023

@alafanechere We need first to merge this in #31606

@alafanechere
Copy link
Contributor Author

@bazarnov it's source-zendesk-chat in this PR, not source-zendesk-support

@airbyte-oss-build-runner
Copy link
Collaborator

source-auth0 test report (commit a6c9bee94c) - ✅

⏲️ Total pipeline duration: 39.94s

Step Result
Build source-auth0 docker image for platform(s) linux/x86_64
Acceptance tests
Code format checks
Validate metadata for source-auth0
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-auth0 test

@airbyte-oss-build-runner
Copy link
Collaborator

source-zendesk-chat test report (commit a6c9bee94c) - ❌

⏲️ Total pipeline duration: 01mn10s

Step Result
Build source-zendesk-chat docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-zendesk-chat
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-chat test

@airbyte-oss-build-runner
Copy link
Collaborator

source-paypal-transaction test report (commit a6c9bee94c) - ✅

⏲️ Total pipeline duration: 01mn11s

Step Result
Build source-paypal-transaction docker image for platform(s) linux/x86_64
Acceptance tests
Code format checks
Validate metadata for source-paypal-transaction
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-paypal-transaction test

@alafanechere
Copy link
Contributor Author

Merging as the source-zendesk-chat failure looks related to an "expected records" drift. The difference between base image 1.0.0 and 1.1.0 is only that socat is installed on 1.1.0, which does not relate on how the connector handles records.

@alafanechere alafanechere merged commit 0deec79 into master Oct 20, 2023
28 of 30 checks passed
@alafanechere alafanechere deleted the augustin/10-20-source-zendesk-chat_source-auth0_update_the_base_image branch October 20, 2023 09:49
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
…q#31643)

Co-authored-by: alafanechere <alafanechere@users.noreply.github.com>
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
…q#31643)

Co-authored-by: alafanechere <alafanechere@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants