Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source [Hubspot, Zendesk-Support]: fix stream schemas #31606

Merged
merged 4 commits into from Oct 20, 2023

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Oct 19, 2023

What

Based on these test reports:

How

  • added missing fields:
    • hubspot: aifeatures to the marketing emails stream schema
    • zendesk-support: reply_time_in_seconds to the ticket metrics stream schema
  • removed cross-dependency between setup.py and airbyte-cdk for source-hubspot
  • updated expected records for both sources

🚨 User Impact 🚨

No impact is expected, the fields are added on top of the schema with no breaking changes.

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 9:46am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 19, 2023
@bazarnov bazarnov self-assigned this Oct 19, 2023
@bazarnov bazarnov marked this pull request as ready for review October 19, 2023 11:39
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 19, 2023 11:41
@airbyte-oss-build-runner

This comment was marked as outdated.

@airbyte-oss-build-runner

This comment was marked as outdated.

@airbyte-oss-build-runner

This comment was marked as outdated.

@airbyte-oss-build-runner
Copy link
Collaborator

source-zendesk-support test report (commit e0a8e745b1) - ✅

⏲️ Total pipeline duration: 07mn29s

Step Result
Build source-zendesk-support docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-zendesk-support
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@airbyte-oss-build-runner
Copy link
Collaborator

source-hubspot test report (commit e0a8e745b1) - ✅

⏲️ Total pipeline duration: 13mn09s

Step Result
Build source-hubspot docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for source-hubspot
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@bazarnov bazarnov merged commit 831de1d into master Oct 20, 2023
27 checks passed
@bazarnov bazarnov deleted the baz/source-hubspot,zendesk-support/fix-schemas branch October 20, 2023 10:05
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

5 participants