source-hubspot: migrate to base image

[alafanechere]

What

Migrating source-hubspot myself as I noticed the build fails when using our new base image.

How

airbyte-ci connectors --name=source-hubspot migrate_to_base_image 31644

I fixed the build by removing the requests explicit dependency. This connector will get requests from the CDK deps.

We have to wait for #31606 to be mainlined to fix CAT run

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 20, 2023 10:30am

[alafanechere]

Current dependencies on/for this PR:

• master
  • PR source-hubspot: migrate to base image #31644 👈

This comment was auto-generated by Graphite.

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[alafanechere]

requests is already an airbyte-cdk transitive dependency.
Pinning it to an "old" 2.26.0 version leads to the following error when running spec:

│ │     ┃ Traceback (most recent call last):
│ │     ┃   File "/airbyte/integration_code/main.py", line 8, in <module>
│ │     ┃     from airbyte_cdk.entrypoint import launch
│ │     ┃   File "/usr/local/lib/python3.9/site-packages/airbyte_cdk/__init__.py", line 6, in <module>
│ │     ┃     from .entrypoint import AirbyteEntrypoint
│ │     ┃   File "/usr/local/lib/python3.9/site-packages/airbyte_cdk/entrypoint.py", line 17, in <module>
│ │     ┃     import requests
│ │     ┃   File "/usr/local/lib/python3.9/site-packages/requests/__init__.py", line 100, in <module>
│ │     ┃     check_compatibility(urllib3.__version__, chardet_version, charset_normalizer_version)
│ │     ┃   File "/usr/local/lib/python3.9/site-packages/requests/__init__.py", line 85, in check_compatibility
│ │     ┃     raise Exception("You need either charset_normalizer or chardet installed")
│ │     ┃ Exception: You need either charset_normalizer or chardet installed

Remove requests from setup.py ensure the connector will use whatever version the CDK needs. The request's CDK version does not lead to this error when it's built inside or python base image.

[bazarnov]

I'm going to fix this here: #31606

[alafanechere]

@bazarnov let me know when #31606 is merged and I'll update this branch

[bazarnov]

@alafanechere final CI checks for this one #31606 and we're good to go. I've also cleared the main dependencies in setup.py.

[bazarnov]

@alafanechere It's merged.

[airbyte-oss-build-runner]

source-hubspot test report (commit 78bdcb0594) - ❌

⏲️ Total pipeline duration: 12mn13s

Step	Result
Build source-hubspot docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-hubspot	✅
Connector version semver check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

[airbyte-oss-build-runner]

source-hubspot test report (commit fd1a4790b7) - ✅

⏲️ Total pipeline duration: 13mn19s

Step	Result
Build source-hubspot docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Check our base image is used	✅
Code format checks	✅
Validate metadata for source-hubspot	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test