Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Server init conditional #3169

Merged
merged 4 commits into from
May 3, 2021
Merged

Change Server init conditional #3169

merged 4 commits into from
May 3, 2021

Conversation

marcosmarxm
Copy link
Member

What

Resolves #3168.

Steps to reproduce error (airbyte 0.22.0-alpha):

  1. docker-compose up
  2. docker-compose down
  3. docker-compose up

Server logs for the second run:
airbyte-server.log

How

Change conditional and function isCompatible to return true if is compatible.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. ServerApp.java
  2. AirbyteVersion.java

@auto-assign auto-assign bot requested a review from sherifnada May 2, 2021 13:53
@marcosmarxm marcosmarxm added the area/platform issues related to the platform label May 3, 2021
jrhizor
jrhizor approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to get this in today and have a point release so people trying out Airbyte don't run into this issue.

airbyte-server/src/main/java/io/airbyte/server/ServerApp.java Outdated Show resolved Hide resolved
@marcosmarxm marcosmarxm merged commit cd7a4f7 into master May 3, 2021
@marcosmarxm marcosmarxm deleted the marcosmarxm/change-server-init-conditional branch May 3, 2021 15:34
@michel-tricot
Copy link
Contributor

Thanks @marcosmarxm !

@marcosmarxm marcosmarxm mentioned this pull request May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

@ChristopheDuong ChristopheDuong ChristopheDuong approved these changes

@cgardens cgardens Awaiting requested review from cgardens

@sherifnada sherifnada Awaiting requested review from sherifnada

Assignees
No one assigned
Labels
area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version mismatch between 0.22.0-alpha and 0.22.0-alpha
4 participants
@marcosmarxm @michel-tricot @jrhizor @ChristopheDuong