Allow passing --use-local-cdk to prerelease publish
#31716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
erohmensing
changed the title
--use-local-cdk to prerelease publish
erohmensing
commented
Oct 23, 2023
Comment on lines
54
to
55
| if use_local_cdk and not self.pre_release: | ||
| raise ValueError("Publishing with the local CDK is only supported for pre-release publishing.") |
There was a problem hiding this comment.
Not sure if there is a better place to perform this validation? In the publish pipeline perhaps?
alafanechere
approved these changes
Oct 23, 2023
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/publish/context.py
Outdated
Show resolved
Hide resolved
erohmensing
commented
Oct 23, 2023
erohmensing
commented
Oct 24, 2023
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/publish/context.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/publish/commands.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
--use-local-cdkafter their--name=argument in the workflow (options to pass to the connectors group).How
--use-local-cdkarg into PublishConnectorContext, which will pass it into the ConnectorContext used for build🚨 User Impact 🚨
None