Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing --use-local-cdk to prerelease publish #31716

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Allow passing --use-local-cdk to prerelease publish #31716

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
198622e
pass cdk into publish command
erohmensing Oct 23, 2023
9f51109
validate options and increment version
erohmensing Oct 23, 2023
a903d27
Apply suggestions from code review
erohmensing Oct 23, 2023
987a21b
Merge branch 'master' into ella/publish-local-cdk
erohmensing Oct 23, 2023
0106dba
Merge branch 'master' into ella/publish-local-cdk
erohmensing Oct 23, 2023
1e279ec
make param optional
erohmensing Oct 24, 2023
ae2d63b
Merge branch 'master' into ella/publish-local-cdk
erohmensing Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions airbyte-ci/connectors/pipelines/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,7 @@ This command runs the Python tests for a airbyte-ci poetry package.
## Changelog
| Version | PR | Description |
| ------- | ---------------------------------------------------------- | --------------------------------------------------------------------------------------------------------- |
| 2.3.0 | [#31716](https://github.com/airbytehq/airbyte/pull/31716) | Enable pre-release publish with local CDK.
| 2.2.5 | [#31718](https://github.com/airbytehq/airbyte/pull/31718) | Authenticate the sidecar docker daemon to DockerHub. |
| 2.2.4 | [#31535](https://github.com/airbytehq/airbyte/pull/31535) | Improve gradle caching when building java connectors. |
| 2.2.3 | [#31688](https://github.com/airbytehq/airbyte/pull/31688) | Fix failing `CheckBaseImageUse` step when not running on PR. |
Expand Down
1 change: 1 addition & 0 deletions airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/publish/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ def publish(
pull_request=ctx.obj.get("pull_request"),
s3_build_cache_access_key_id=ctx.obj.get("s3_build_cache_access_key_id"),
s3_build_cache_secret_key=ctx.obj.get("s3_build_cache_secret_key"),
use_local_cdk=ctx.obj["use_local_cdk"],
erohmensing marked this conversation as resolved.
Show resolved Hide resolved
)
for connector in ctx.obj["selected_connectors_with_modified_files"]
]
Expand Down
5 changes: 5 additions & 0 deletions airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/publish/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def __init__(
pull_request: PullRequest = None,
s3_build_cache_access_key_id: Optional[str] = None,
s3_build_cache_secret_key: Optional[str] = None,
use_local_cdk: bool = False,
erohmensing marked this conversation as resolved.
Show resolved Hide resolved
):
self.pre_release = pre_release
self.spec_cache_bucket_name = spec_cache_bucket_name
Expand All @@ -50,6 +51,9 @@ def __init__(
pipeline_name = f"Publish {connector.technical_name}"
pipeline_name = pipeline_name + " (pre-release)" if pre_release else pipeline_name

if use_local_cdk and not self.pre_release:
raise click.UsageError("Publishing with the local CDK is only supported for pre-release publishing.")

super().__init__(
pipeline_name=pipeline_name,
connector=connector,
Expand All @@ -66,6 +70,7 @@ def __init__(
reporting_slack_channel=reporting_slack_channel,
ci_gcs_credentials=ci_gcs_credentials,
should_save_report=True,
use_local_cdk=use_local_cdk,
docker_hub_username=docker_hub_username,
docker_hub_password=docker_hub_password,
s3_build_cache_access_key_id=s3_build_cache_access_key_id,
Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/pipelines/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "pipelines"
version = "2.2.5"
version = "2.3.0"
description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
authors = ["Airbyte <contact@airbyte.io>"]

Expand Down