-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Notion: add 'synced block' property and date format #31742
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
|
Step | Result |
---|---|
Build source-notion docker image for platform(s) linux/amd64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Check our base image is used | ✅ |
Code format checks | ✅ |
Validate metadata for source-notion | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-notion test
|
Step | Result |
---|---|
Build source-notion docker image for platform(s) linux/amd64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Check our base image is used | ✅ |
Code format checks | ✅ |
Validate metadata for source-notion | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-notion test
|
Step | Result |
---|---|
Build source-notion docker image for platform(s) linux/amd64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Check our base image is used | ✅ |
Code format checks | ✅ |
Validate metadata for source-notion | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-notion test
docs/integrations/sources/notion.md
Outdated
@@ -112,6 +112,7 @@ The connector is restricted by Notion [request limits](https://developers.notion | |||
|
|||
| Version | Date | Pull Request | Subject | | |||
| :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------------------------- | | |||
| 2.0.5 | 2023-10-23 | [31742](https://github.com/airbytehq/airbyte/pull/31742) | Add 'synced_block' property to Blocks schema | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: please format this table 🙏
…ehq/airbyte into christo/notion-schema-fix
|
Step | Result |
---|---|
Build source-notion docker image for platform(s) linux/amd64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Check our base image is used | ✅ |
Code format checks | ✅ |
Validate metadata for source-notion | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-notion test
What
Small fixes for Source Notion Silver Certification.
synced_block
Block type.How
Synced blocks can consist of "original synced blocks" or "duplicated sync blocks":
synced_from
property, and may contain achildren
array of Blocks objects.synced_from
property contains atype
ofblock_id
and ablock_id
key; these blocks have nochildren
array.Docs link
User Impact
Backwards compatibility tests were failing due to the addition of the "date-time" format for the specified fields. However, my understanding is these changes should not constitute a breaking change, as this PR contains only additions of missing properties and formats. I'd like to confirm that this is correct and we can safely merge without necessitating a breaking change migration.