Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Notion: add 'synced block' property and date format #31742

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Source Notion: add 'synced block' property and date format #31742

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
192a6cd
add date formats and synced block
ChristoGrab Oct 23, 2023
c92b287
Merge branch 'master' into christo/notion-schema-fix
ChristoGrab Oct 23, 2023
2573552
rework synced block schema
ChristoGrab Oct 23, 2023
6ac496f
docs changelog
ChristoGrab Oct 23, 2023
6dd4f54
Merge branch 'master' into christo/notion-schema-fix
ChristoGrab Oct 23, 2023
085beee
Automated Commit - Formatting Changes
ChristoGrab Oct 23, 2023
9bf48d6
format changelog
ChristoGrab Oct 24, 2023
50104de
Merge branch 'christo/notion-schema-fix' of https://github.com/airbyt…
ChristoGrab Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-notion/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ acceptance_tests:
tests:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
disable_for_version: 1.3.0
disable_for_version: 2.0.4
basic_read:
tests:
- config_path: "secrets/config.json"
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-notion/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 6e00b415-b02e-4160-bf02-58176a0ae687
dockerImageTag: 2.0.4
dockerImageTag: 2.0.5
dockerRepository: airbyte/source-notion
documentationUrl: https://docs.airbyte.com/integrations/sources/notion
githubIssueLabel: source-notion
Expand Down
24 changes: 24 additions & 0 deletions airbyte-integrations/connectors/source-notion/source_notion/schemas/blocks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,30 @@
"paragraph": { "$ref": "text_element.json" },
"pdf": { "$ref": "file.json" },
"quote": { "$ref": "text_element.json" },
"synced_block": {
"type": "object",
"properties": {
"synced_from": {
"type": ["null", "object"],
"properties": {
"type": {
"type": "string",
"enum": ["block_id"]
},
"block_id": {
"type": "string"
}
}
},
"children": {
"type": ["null", "array"],
"items": {
"type": ["null", "object"],
"additionalProperties": true
}
}
}
},
"table": {
"type": "object",
"properties": {
Expand Down
9 changes: 6 additions & 3 deletions airbyte-integrations/connectors/source-notion/source_notion/schemas/comments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,16 @@
"type": "string"
},
"created_time": {
"type": "string"
"type": "string",
"format": "date-time"
},
"last_edited_time": {
"type": "string"
"type": "string",
"format": "date-time"
},
"page_last_edited_time": {
"type": "string"
"type": "string",
"format": "date-time"
},
"created_by": {
"$ref": "user.json"
Expand Down
3 changes: 2 additions & 1 deletion airbyte-integrations/connectors/source-notion/source_notion/schemas/shared/file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"type": "string"
},
"expiry_time": {
"type": "string"
"type": "string",
"format": "date-time"
}
}
}
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/notion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ The connector is restricted by Notion [request limits](https://developers.notion

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------------------------- |
| 2.0.5 | 2023-10-23 | [31742](https://github.com/airbytehq/airbyte/pull/31742) | Add 'synced_block' property to Blocks schema |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please format this table 🙏

| 2.0.4 | 2023-10-19 | [31625](https://github.com/airbytehq/airbyte/pull/31625) | Fix check_connection method |
| 2.0.3 | 2023-10-19 | [31612](https://github.com/airbytehq/airbyte/pull/31612) | Add exponential backoff for 500 errors |
| 2.0.2 | 2023-10-19 | [31599](https://github.com/airbytehq/airbyte/pull/31599) | Base image migration: remove Dockerfile and use the python-connector-base image |
Expand Down
Loading