🐛 Source Bing Ads: campaigns, accounts, search query report streams: update schemas + date-time convert rfc3339
#31995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
davydov-d
approved these changes
Oct 31, 2023
darynaishchenko
requested review from
pedroslopez,
katmarkham,
a team and
artem1205
artem1205
approved these changes
Oct 31, 2023
pedroslopez
requested review from
alafanechere
and removed request for
pedroslopez
alafanechere
requested changes
Nov 2, 2023
There was a problem hiding this comment.
The change looks good to me but I believe the CAT failure is related to an expected_records failure. Shall we udpate these expected records following the schema change?
@davydov-d told me that the file size 260506229 exceeds limit 134217728 we see in the CAT report is often related to expected records test failure.
katmarkham
requested changes
Nov 2, 2023
katmarkham
approved these changes
Nov 8, 2023
…ads/validation-errors # Conflicts: # airbyte-integrations/connectors/source-bing-ads/integration_tests/expected_records.jsonl # airbyte-integrations/connectors/source-bing-ads/metadata.yaml # airbyte-integrations/connectors/source-bing-ads/source_bing_ads/reports.py # airbyte-integrations/connectors/source-bing-ads/source_bing_ads/source.py # airbyte-integrations/connectors/source-bing-ads/source_bing_ads/streams.py # airbyte-integrations/connectors/source-bing-ads/unit_tests/test_source.py # docs/integrations/sources/bing-ads.md
…ads/validation-errors # Conflicts: # docs/integrations/sources/bing-ads.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Based on datadog dashboard:
validation_error:_.linkedagencies:_object_found_but_null_string_is_requiredvalidation_error:_.biddingscheme.maxcpc.amount:_number_found_but_null_string_is_requiredvalidation_error:_.costperconversion:_string_found_but_null_integer_is_requiredConvert
dateanddate-timefields to standardRFC3339.save stream_state in "native" field format
How
Recommended reading order
schemas/*.jsonstreams.pyreport_streams.pyutils.py🚨 User Impact 🚨
This version update affects next streams:
Version 2.0.0 updates schemas for Accounts, Campaigns and Search Query Performance Report streams. LinkedAgencies was changed from string to object in Accounts stream.
BiddingScheme.MaxCpc.Amount was changed from string to number in Campaigns stream. And CostPerConversion was changed from integer to number.
All
dateanddate-timefields will be converted to standardRFC3339.For the changes to take effect, please refresh the source schema and reset affected streams after you have applied the upgrade.
RFC3339)AppInstallAds,AppInstallAdLabels,Labels,Campaign Labels,Keyword Labels,Ad Group Labels,KeywordsModified Time04/27/2023 18:00:14.9702023-04-27T16:00:14.970+00:00Budget Summary ReportDate6/10/20212021-06-10* Report HourlyTimePeriod2023-11-04|112023-11-04T11:00:00+00:00