Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Bing Ads: campaigns, accounts, search query report streams: update schemas + date-time convert rfc3339 #31995

Merged
merged 55 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
4ec2921
campaings, accounts, search query report: update schema
darynaishchenko Oct 31, 2023
7520477
updated changelog
darynaishchenko Oct 31, 2023
c68b72c
Automated Commit - Formatting Changes
darynaishchenko Oct 31, 2023
770fc64
updated migration guides
darynaishchenko Nov 2, 2023
84106e1
Merge remote-tracking branch 'origin' into daryna/source-bing-ads/val…
darynaishchenko Nov 2, 2023
54964ba
Merge remote-tracking branch 'origin/master' into daryna/source-bing-…
artem1205 Nov 3, 2023
4c7a01d
Source Bing Ads: update unit tests + refactor
artem1205 Nov 3, 2023
dab57c7
Automated Commit - Formatting Changes
artem1205 Nov 3, 2023
1c65961
Source Bing Ads: refactor; update state; transform date & datetime fi…
artem1205 Nov 5, 2023
8e4c25c
Source Bing Ads: update unit tests
artem1205 Nov 5, 2023
6335706
Source Bing Ads: ref
artem1205 Nov 5, 2023
f11c8f7
Source Bing Ads: update expected records
artem1205 Nov 5, 2023
5821409
Automated Commit - Formatting Changes
artem1205 Nov 5, 2023
e5f8ffb
Source Bing Ads: update daily schemas
artem1205 Nov 5, 2023
dcbed18
Source Bing Ads: update houlry schema ad performance
artem1205 Nov 5, 2023
0754dd9
Merge remote-tracking branch 'origin/daryna/source-bing-ads/validatio…
artem1205 Nov 5, 2023
4cba7bf
Source Bing Ads: update hourly schemas
artem1205 Nov 5, 2023
0510bb5
Source Bing Ads: update sample state
artem1205 Nov 5, 2023
95ec485
Merge remote-tracking branch 'origin/master' into daryna/source-bing-…
artem1205 Nov 6, 2023
813bfa9
Source Bing Ads: fix merge conflict parent_key_to_foreign_key_map
artem1205 Nov 6, 2023
696a96b
Source Bing Ads: update docs
artem1205 Nov 6, 2023
57f10f7
Source Bing Ads: update docs
artem1205 Nov 6, 2023
5d90323
Source Bing Ads: update Metadata messages
artem1205 Nov 6, 2023
fa9f6a4
Merge remote-tracking branch 'origin/master' into daryna/source-bing-…
artem1205 Nov 6, 2023
f8f3c79
Source Bing Ads: update docs
artem1205 Nov 6, 2023
69d8d95
Source Bing Ads: add unit tests for hourly reports
artem1205 Nov 6, 2023
431f0c1
Automated Commit - Formatting Changes
artem1205 Nov 6, 2023
eef2b26
Source Bing Ads: add unit tests for daily reports
artem1205 Nov 6, 2023
b40aead
Source Bing Ads: fix state parse
artem1205 Nov 6, 2023
e987ac0
Merge remote-tracking branch 'origin/daryna/source-bing-ads/validatio…
artem1205 Nov 6, 2023
3a84f88
Source Bing Ads: update docs
artem1205 Nov 6, 2023
a70b4de
Merge remote-tracking branch 'origin/master' into daryna/source-bing-…
artem1205 Nov 7, 2023
e3c011d
Source Bing Ads: fix merge conflict
artem1205 Nov 7, 2023
8f1080c
Source Bing Ads: update metadata message
artem1205 Nov 7, 2023
7315f6e
Merge remote-tracking branch 'origin/master' into daryna/source-bing-…
artem1205 Nov 14, 2023
87a5a54
Source Bing Ads: remove old files
artem1205 Nov 14, 2023
93954ca
Source Bing Ads: fix merge conflicts
artem1205 Nov 14, 2023
fe94f1d
Source Bing Ads: fix merge conflicts
artem1205 Nov 14, 2023
c026423
Source Bing Ads: refactor
artem1205 Nov 15, 2023
853f8dc
Source Bing Ads: fix for summary report type
artem1205 Nov 15, 2023
8f3c489
Source Bing Ads: refactor tests
artem1205 Nov 15, 2023
566c052
Source Bing Ads: add tests
artem1205 Nov 15, 2023
071727a
Source Bing Ads: add tests
artem1205 Nov 15, 2023
3d30efa
Source Bing Ads: update accounts schema
artem1205 Nov 15, 2023
448656a
Source Bing Ads: update expected records
artem1205 Nov 15, 2023
56331f0
Source Bing Ads: update setup deps
artem1205 Nov 15, 2023
13ddc66
Source Bing Ads: update default time periods
artem1205 Nov 15, 2023
cbf9fef
Merge branch 'master' into daryna/source-bing-ads/validation-errors
artem1205 Nov 15, 2023
8b1417e
Source Bing Ads: fix empty cursor field value state update
artem1205 Nov 15, 2023
9f38cd4
Source Bing Ads: fix schema
artem1205 Nov 15, 2023
109db56
Source Bing Ads: update expected records
artem1205 Nov 15, 2023
196efc4
Source Bing Ads: update expected records
artem1205 Nov 15, 2023
857efe2
Source Bing Ads: update expected records
artem1205 Nov 15, 2023
29839fc
Source Bing Ads: update upgradeDeadline
artem1205 Nov 15, 2023
2fd18d3
Merge remote-tracking branch 'origin/master' into daryna/source-bing-…
artem1205 Nov 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ acceptance_tests:
discovery:
tests:
- config_path: secrets/config.json
backward_compatibility_tests_config:
disable_for_version: "1.4.0"
connection:
tests:
- config_path: secrets/config.json
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"stream": {
"stream_state": {
"180278106": {
"TimePeriod": 1627820152
"TimePeriod": "2021-08-01T14:00:00+00:00"
}
},
"stream_descriptor": { "name": "keyword_performance_report_hourly" }
Expand All @@ -15,32 +15,32 @@
"stream": {
"stream_state": {
"180278106": {
"Date": 1627800152
"Date": "2021-08-01"
}
},
"stream_descriptor": { "name": "budget_summary_report_hourly" }
"stream_descriptor": { "name": "budget_summary_report" }
}
},
{
"type": "STREAM",
"stream": {
"stream_state": {
"180278106": {
"TimePeriod": 1627795152
"TimePeriod": "2021-08-01"
}
},
"stream_descriptor": { "name": "ad_performance_report_hourly" }
"stream_descriptor": { "name": "ad_performance_report_weekly" }
}
},
{
"type": "STREAM",
"stream": {
"stream_state": {
"180278106": {
"TimePeriod": 1727810152
"TimePeriod": "2023-04-27T15:16:49.170+00:00"
}
},
"stream_descriptor": { "name": "campaign_performance_report_hourly" }
"stream_descriptor": { "name": "labels" }
}
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
dockerImageTag: 1.11.0
dockerImageTag: 2.0.0
dockerRepository: airbyte/source-bing-ads
documentationUrl: https://docs.airbyte.com/integrations/sources/bing-ads
githubIssueLabel: source-bing-ads
Expand All @@ -39,6 +39,11 @@ data:
primary keys. A data reset and schema refresh of all the affected streams
is required for the changes to take effect.
upgradeDeadline: "2023-10-25"
2.0.0:
message: >
Version 2.0.0 updates schemas for all hourly reports (end in report_hourly), and the following streams: Accounts, Campaigns, Search Query Performance Report, AppInstallAds, AppInstallAdLabels, Labels, Campaign Labels, Keyword Labels, Ad Group Labels, Keywords, and Budget Summary Report.
Users will need to refresh the source schema and reset affected streams after upgrading.
upgradeDeadline: "2023-11-17"
suggestedStreams:
streams:
- campaigns
Expand Down
Loading
Loading