Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Amazon Seller Partner: improve UX #32505

Merged
merged 54 commits into from
Nov 29, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Nov 14, 2023

What

Resolve #32225

How

Refactor report options

image
image
image

Report options in config :

"report_options_list": [
            {
                "stream_name": "GET_FBA_FULFILLMENT_CUSTOMER_RETURNS_DATA",
                "options_list": [
                    {
                        "option_name": "some_name_1",
                        "option_value": "some_value_1"
                    },

                    {
                        "option_name": "some_name_2",
                        "option_value": "some_value_2"
                    }
                ]
            }
        ]

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 11:49am

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Nov 14, 2023
Copy link
Contributor

github-actions bot commented Nov 14, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 changed the title Source Bing Ads: improve UX Source Amazon Seller Partner: improve UX Nov 14, 2023
…artner-spec-refactor' into artem1205/source-amazon-seller-partner-spec-refactor
…azon-seller-partner-spec-refactor

# Conflicts:
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_stream_sales_and_traffic.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_streams_rate_limits.py
…azon-seller-partner-spec-refactor

# Conflicts:
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json
@artem1205 artem1205 changed the title Source Amazon Seller Partner: improve UX ✨ Source Amazon Seller Partner: improve UX Nov 17, 2023
…azon-seller-partner-spec-refactor

# Conflicts:
#	airbyte-integrations/connectors/source-amazon-seller-partner/integration_tests/spec.json
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_order_items_stream.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_stream_sales_and_traffic.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_streams_settlement_report.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py
@askarpets askarpets marked this pull request as ready for review November 28, 2023 08:37
Base automatically changed from source-amazon-seller-partner to dev November 28, 2023 13:55
git-phu and others added 4 commits November 28, 2023 10:07
…efactor

# Conflicts:
#	airbyte-integrations/connectors/source-amazon-seller-partner/metadata.yaml
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/schemas/GET_VENDOR_TRAFFIC_REPORT.json
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py
#	docs/integrations/sources/amazon-seller-partner.md
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need resolve conflicts before review

@askarpets askarpets changed the base branch from dev to master November 29, 2023 09:11
Anton Karpets added 2 commits November 29, 2023 11:23
…c-refactor

# Conflicts:
#	airbyte-integrations/connectors/source-amazon-seller-partner/metadata.yaml
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py
#	docs/integrations/sources/amazon-seller-partner.md
…artner-spec-refactor' into artem1205/source-amazon-seller-partner-spec-refactor
@askarpets
Copy link
Contributor

@lazebnyi The conflicts have been resolved. Please review, thanks!

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@askarpets askarpets merged commit b77f6e2 into master Nov 29, 2023
25 checks passed
@askarpets askarpets deleted the artem1205/source-amazon-seller-partner-spec-refactor branch November 29, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-seller-partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX of source Amazon Seller Partner