Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Zendesk Support: Fix 504 Error for stream Ticket Audits #33435

Merged
merged 3 commits into from
Dec 14, 2023
Merged

🐛 Source Zendesk Support: Fix 504 Error for stream Ticket Audits #33435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
234f002
Source Zendesk Support: decrease page size to 200
artem1205 Dec 13, 2023
a2b551a
Source Zendesk Support: decrease page size to 200
artem1205 Dec 13, 2023
8d80267
Source Zendesk Support: update unit test
artem1205 Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 79c1aa37-dae3-42ae-b333-d1c105477715
dockerImageTag: 2.2.2
dockerImageTag: 2.2.3
dockerRepository: airbyte/source-zendesk-support
documentationUrl: https://docs.airbyte.com/integrations/sources/zendesk-support
githubIssueLabel: source-zendesk-support
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ class TicketAudits(IncrementalZendeskSupportStream):
"""TicketAudits stream: https://developer.zendesk.com/api-reference/ticketing/tickets/ticket_audits/"""

# can request a maximum of 1,000 results
page_size = 1000
page_size = 200
# ticket audits doesn't have the 'updated_by' field
cursor_field = "created_at"

Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ def test_check_stream_state(self, stream_cls, expected):
(GroupMemberships, {"page[size]": 100, "sort_by": "asc", "start_time": 1622505600}),
(TicketForms, {"start_time": 1622505600}),
(TicketMetricEvents, {"page[size]": 100, "start_time": 1622505600}),
(TicketAudits, {"sort_by": "created_at", "sort_order": "desc", "limit": 1000}),
(TicketAudits, {"sort_by": "created_at", "sort_order": "desc", "limit": 200}),
(SatisfactionRatings, {"page[size]": 100, "sort_by": "asc", "start_time": 1622505600}),
(TicketMetrics, {"page[size]": 100, "start_time": 1622505600}),
(OrganizationMemberships, {"page[size]": 100, "start_time": 1622505600}),
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/zendesk-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ The Zendesk connector ideally should not run into Zendesk API limitations under

| Version | Date | Pull Request | Subject |
|:---------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `2.2.3` | 2023-12-14 | [33435](https://github.com/airbytehq/airbyte/pull/33435) | Fix 504 Error for stream Ticket Audits |
| `2.2.2` | 2023-12-01 | [33012](https://github.com/airbytehq/airbyte/pull/33012) | Increase number of retries for backoff policy to 10 |
| `2.2.1` | 2023-11-10 | [32440](https://github.com/airbytehq/airbyte/pull/32440) | Made refactoring to improve code maintainability |
| `2.2.0` | 2023-10-31 | [31999](https://github.com/airbytehq/airbyte/pull/31999) | Extended the `CustomRoles` stream schema |
Expand Down
Loading