change DataSourceFactory to take the connection timeout as an additional parameter

[stephane-airbyte]

This is an intermediate refactoring that prepares for the next steps. This should have no functional changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Dec 14, 2023 10:01pm

[stephane-airbyte]

Current dependencies on/for this PR:

• master
  • PR use latest image for mssql #33357
    • PR limit memory for MSSQL containers #33358
      • PR pull MSSql debezium classes out of the CDK #33270
        • PR refactor DatasourceBuilder.withConnectionTimeout #33439
          • PR move DataSourceBuilder.getConnectionTimeout to DataSourceFactory #33440
            • PR change DataSourceFactory to take the connection timeout as an additional parameter #33442 👈
              • PR add connectionTimeout parameter to DslContextFactory.create #33443
                • PR move getConnectionTimeout from DataSourceFactory to a new JdbcConnector class #33444
                  • PR AbstractJdbcSource and AbstractJdbcDestination now inherit from JdbcConnector #33445
                  • PR rename driverClass into driverClassName #33470
                  • PR use local CDK in sources MSSQL, MySQL and Postgres #33517
                  • PR provide overridable hooks for abstractJdbcSource.createDatabase #33446
                  • PR override getConnectionTimeout in MssqlSource #33453
                  • PR override getConnectionTimeout in MySqlSource #33454
                  • PR override getConnectionTimeout in PostgresSource #33455
                  • PR move getConnectionTimeout custom logic our of JdbcConnector #33520
                  • PR use latest CDK in certified connectors #33447
                  • PR update CDK and certified connector versions #33473
            • PR update max mem for compilation #33441

This stack of pull requests is managed by Graphite.

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[stephane-airbyte]

Merge activity

• Dec 14, 4:33 PM: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
• Dec 14, 5:10 PM: @@stephane-airbyte merged this pull request with Graphite.