bugfix infinite pagination in CDK #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherifnada
requested review from
yevhenii-ldv,
keu and
davinchia
and removed request for
michel-tricot and
masonwheeler
Merged
sherifnada
commented
May 11, 2021
| @@ -21,7 +21,7 @@ class AirbytePythonPlugin implements Plugin<Project> { | |||
| installVirtualenv = true | |||
| pip 'flake8:3.8.4' | |||
| pip 'black:20.8b1' | |||
| pip 'mypy:0.790' | |||
| pip 'mypy:0.812' | |||
There was a problem hiding this comment.
bump gradle mypy to latest version so running something like gradle format doesn't overwrite with an older mypy version
yevhenii-ldv
approved these changes
May 11, 2021
keu
approved these changes
May 11, 2021
| def test_stub_next_page_token_http_stream_read_records(mocker): | ||
|
|
||
| stream = StubNextPageTokenHttpStream() | ||
| def test_pagination(mocker): |
There was a problem hiding this comment.
can we have a more expressive name?
| getattr(stream, method).assert_any_call(next_page_token=None, stream_slice=None, stream_state={}) # Assert first call happened | ||
| for token in expected_next_page_tokens: | ||
| getattr(stream, method).assert_any_call(next_page_token=token, stream_slice=None, stream_state={}) | ||
|
|
||
| assert [{"data": 1}, {"data": 2}, {"data": 3}, {"data": 4}, {"data": 5}, {"data": 6}] == records |
There was a problem hiding this comment.
or at least get message here why we expect these data and better move expected to separate variable
|
/publish-cdk dry-run=false
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #3363
How
The CDK incorrectly set
next_page_tokentoNoneat the beginning of every pagination loop iteration. Fix this by not settingnext_page_tokeninside the loop.