tuning ssh keepalive settings #33727
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Warning Soft code freeze is in effect until 2024-01-02. Please avoid merging to master. #freedom-and-responsibility |
octavia-squidington-iii
added
area/connectors
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
gisripa
force-pushed
the
gireesh/ssh-timeouts
branch
from
4c6c4c6
to
7eee869
Compare
octavia-squidington-iii
removed
area/documentation
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
| Optional<JsonNode> connectionOptionsConfig = Jsons.getOptional(clone, CONNECTION_OPTIONS_KEY); | ||
| if (connectionOptionsConfig.isEmpty()) { | ||
| LOGGER.info("No SSH connection options found, using defaults"); | ||
| if (clone instanceof ObjectNode) { // Defensive check, it will always be object node |
There was a problem hiding this comment.
nit: you can pattern-match the instanceof to avoid the explicit cast
if (clone instanceof ObjectNode objectClone) {
... = objectClone.putObject(...)
Looks like released already ? I have to test this anyway in one of our workspace before shipping it in CDK |
|
feel free to do a prerelease here - but I need to merge my pr to master (and then you can merge master into this branch) before you can make another cdk release :( also connector publishes might be down (https://airbytehq-team.slack.com/archives/C03VDJ4FMJB/p1704395954729139?thread_ts=1704385086.967279&cid=C03VDJ4FMJB) so I'm holding off on merging my pr until conn ops confirms it's ok 😭 |
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
|
/publish-java-cdk
|
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
What
Shooting in the dark to see if SSH keepalive settings alleviate the woes caused by ssh tunnel closing DB connections
How
Using Apache MINA's configurable properties to try both Session level heartbeats, client level keepalive, TCP keepalive.