-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tuning ssh keepalive settings #33727
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Warning Soft code freeze is in effect until 2024-01-02. Please avoid merging to master. #freedom-and-responsibility |
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
4c6c4c6
to
7eee869
Compare
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I have a CDK release waiting on connector CI in #33730, so, uh, don't actually ship it yet though)
Optional<JsonNode> connectionOptionsConfig = Jsons.getOptional(clone, CONNECTION_OPTIONS_KEY); | ||
if (connectionOptionsConfig.isEmpty()) { | ||
LOGGER.info("No SSH connection options found, using defaults"); | ||
if (clone instanceof ObjectNode) { // Defensive check, it will always be object node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can pattern-match the instanceof to avoid the explicit cast
if (clone instanceof ObjectNode objectClone) {
... = objectClone.putObject(...)
Looks like released already ? I have to test this anyway in one of our workspace before shipping it in CDK |
feel free to do a prerelease here - but I need to merge my pr to master (and then you can merge master into this branch) before you can make another cdk release :( also connector publishes might be down (https://airbytehq-team.slack.com/archives/C03VDJ4FMJB/p1704395954729139?thread_ts=1704385086.967279&cid=C03VDJ4FMJB) so I'm holding off on merging my pr until conn ops confirms it's ok 😭 |
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
/publish-java-cdk
|
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
What
Shooting in the dark to see if SSH keepalive settings alleviate the woes caused by ssh tunnel closing DB connections
How
Using Apache MINA's configurable properties to try both Session level heartbeats, client level keepalive, TCP keepalive.