Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destination-redshift: Heartbeats for bastion and other minor bugfixes #33948

Merged
merged 22 commits into from
Jan 8, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jan 4, 2024

What

Fixes: #33945
Fixes: #33900

Potentially Fixes: #33643

How

See CDK changes #33727
Adding addition redshift connectTimeout from default 10s

Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 0:08am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 4, 2024
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
@gisripa gisripa changed the title Gireesh/redshift/ssh testing destination-redshift: Heartbeats for bastion and other minor bugfixes Jan 5, 2024
@gisripa gisripa removed the CDK Connector Development Kit label Jan 5, 2024
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth also releasing bigquery+snowflake for the T+D setup fix?

@gisripa
Copy link
Contributor Author

gisripa commented Jan 5, 2024

maybe worth also releasing bigquery+snowflake for the T+D setup fix?

Oh right. DefaultTD is a project dependency right ? so just version bumps should do ?

@edgao
Copy link
Contributor

edgao commented Jan 5, 2024

just version bumps should do

yep

Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits, otherwise lgtm!

gisripa and others added 3 commits January 5, 2024 14:55
…integration/resources/sqlgenerator/alltypes_expectedrecords_final.jsonl

Co-authored-by: Edward Gao <edward.gao@airbyte.io>
…java/io/airbyte/integrations/destination/redshift/RedshiftStagingS3Destination.java

Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 6, 2024
@gisripa gisripa merged commit 7503dc7 into master Jan 8, 2024
25 checks passed
@gisripa gisripa deleted the gireesh/redshift/ssh-testing branch January 8, 2024 17:09
@gisripa gisripa self-assigned this Jan 8, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…airbytehq#33948)

Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…airbytehq#33948)

Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…airbytehq#33948)

Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants