-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Facebook Marketing: Convert to airbyte-lib #33934
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change looks good but I haven't tested the entrypoint
@@ -25,4 +25,9 @@ | |||
extras_require={ | |||
"tests": TEST_REQUIREMENTS, | |||
}, | |||
entry_points={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the best way to test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, the easiest way is this:
- Go to
airbyte-lib
- Get a shell:
poetry shell
- Go to the connector directory
- Install into current venv:
pip install .
- Open python REPL:
python
- Use the connector with
use_local_install=True
:
import airbyte_lib as ab
c = ab.get_connector("source-facebook-marketing", config={... config object ...}, use_local_install=True)
# test things
c.check()
c.get_available_streams()
next(c.read_stream("<stream name>"))
Make the connector ready to be consumed by airbyte-lib