Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Facebook Marketing: Convert to airbyte-lib #33934

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

flash1293
Copy link
Contributor

Make the connector ready to be consumed by airbyte-lib

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 9:20am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing labels Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@flash1293 flash1293 marked this pull request as ready for review January 4, 2024 15:45
@flash1293 flash1293 changed the title Source facebook marketing: Convert to airbyte-lib Source Facebook Marketing: Convert to airbyte-lib Jan 4, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 4, 2024 15:46
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good but I haven't tested the entrypoint

@@ -25,4 +25,9 @@
extras_require={
"tests": TEST_REQUIREMENTS,
},
entry_points={
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the best way to test this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, the easiest way is this:

  • Go to airbyte-lib
  • Get a shell: poetry shell
  • Go to the connector directory
  • Install into current venv: pip install .
  • Open python REPL: python
  • Use the connector with use_local_install=True:
import airbyte_lib as ab

c = ab.get_connector("source-facebook-marketing", config={... config object ...}, use_local_install=True)

# test things

c.check()

c.get_available_streams()

next(c.read_stream("<stream name>"))

@flash1293 flash1293 merged commit 94f981c into master Jan 9, 2024
26 of 27 checks passed
@flash1293 flash1293 deleted the flash1293/airbyte-lib-facebook-marketing branch January 9, 2024 10:30
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants