Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Facebook Marketing: Convert to airbyte-lib #33934

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Source Facebook Marketing: Convert to airbyte-lib #33934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8d858b
convert
Jan 4, 2024
4737d40
Update facebook-marketing.md
Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions airbyte-integrations/connectors/source-facebook-marketing/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@
#


import sys

from airbyte_cdk.entrypoint import launch
from source_facebook_marketing import SourceFacebookMarketing
from source_facebook_marketing.run import run

if __name__ == "__main__":
source = SourceFacebookMarketing()
launch(source, sys.argv[1:])
run()
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c
dockerImageTag: 1.2.2
dockerImageTag: 1.2.3
dockerRepository: airbyte/source-facebook-marketing
documentationUrl: https://docs.airbyte.com/integrations/sources/facebook-marketing
githubIssueLabel: source-facebook-marketing
Expand Down
5 changes: 5 additions & 0 deletions airbyte-integrations/connectors/source-facebook-marketing/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,9 @@
extras_require={
"tests": TEST_REQUIREMENTS,
},
entry_points={
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the best way to test this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, the easiest way is this:

  • Go to airbyte-lib
  • Get a shell: poetry shell
  • Go to the connector directory
  • Install into current venv: pip install .
  • Open python REPL: python
  • Use the connector with use_local_install=True:
import airbyte_lib as ab

c = ab.get_connector("source-facebook-marketing", config={... config object ...}, use_local_install=True)

# test things

c.check()

c.get_available_streams()

next(c.read_stream("<stream name>"))

"console_scripts": [
"source-facebook-marketing=source_facebook_marketing.run:run",
],
},
)
15 changes: 15 additions & 0 deletions airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#


import sys

from airbyte_cdk.entrypoint import launch

from .source import SourceFacebookMarketing


def run():
source = SourceFacebookMarketing()
launch(source, sys.argv[1:])
1 change: 1 addition & 0 deletions docs/integrations/sources/facebook-marketing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ The Facebook Marketing connector uses the `lookback_window` parameter to repeate

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 1.2.3 | 2024-01-04 | [33934](https://github.com/airbytehq/airbyte/pull/33828) | Make ready for airbyte-lib |
| 1.2.2 | 2024-01-02 | [33828](https://github.com/airbytehq/airbyte/pull/33828) | Add insights job timeout to be an option, so a user can specify their own value |
| 1.2.1 | 2023-11-22 | [32731](https://github.com/airbytehq/airbyte/pull/32731) | Removed validation that blocked personal ad accounts during `check` |
| 1.2.0 | 2023-10-31 | [31999](https://github.com/airbytehq/airbyte/pull/31999) | Extend the `AdCreatives` stream schema |
Expand Down
Loading