Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: Revert mypy changes #33954

Merged
merged 4 commits into from
Jan 4, 2024
Merged

airbyte-ci: Revert mypy changes #33954

merged 4 commits into from
Jan 4, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jan 4, 2024

This reverts commit 917f420.

@airbytehq/connector-operations do I need to bump the airbyte-ci version + add another changelog entry?

hopefully this will fix the publish workflow? context https://airbytehq-team.slack.com/archives/C03VDJ4FMJB/p1704398278393879?thread_ts=1704385086.967279&cid=C03VDJ4FMJB
image

@edgao edgao requested a review from a team January 4, 2024 21:05
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 9:41pm

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgao can you please also revert this follow up PR that was bunched into the one you've reverted but was missed the first time around?

Yes, please bump the version in order to get it to release a new binary

@erohmensing erohmensing enabled auto-merge (squash) January 4, 2024 21:40
@erohmensing erohmensing merged commit 0a3b8e7 into master Jan 4, 2024
19 checks passed
@erohmensing erohmensing deleted the edgao/revert_airbyteci branch January 4, 2024 21:59
Copy link

sentry-io bot commented Jan 5, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NameError: name 'ConnectorReport' is not defined pipelines.models.contexts.pipeline_context in g... View Issue

Did you find this useful? React with a 👍 or 👎

jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: erohmensing <erohmensing@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: erohmensing <erohmensing@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: erohmensing <erohmensing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants