Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: re-introduce mypy #33964

Merged

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 5, 2024

What

Re-introduce changes from #33785 which got reverted due to a regression on test and publish pipeline:

  • Publish pipelines raised an assertion error
  • Connector test pipelines were not setting the test report url correctly on commit status

How

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 10:14am

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alafanechere alafanechere force-pushed the augustin/01-05-airbyte-ci_re-introduce_mypy branch from b3e3c7a to de1c1cc Compare January 5, 2024 09:58
@alafanechere alafanechere marked this pull request as ready for review January 5, 2024 09:59
@alafanechere alafanechere requested a review from a team January 5, 2024 09:59
@alafanechere alafanechere force-pushed the augustin/01-05-airbyte-ci_re-introduce_mypy branch from de1c1cc to 4de9510 Compare January 5, 2024 10:12
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Jan 5, 2024
@alafanechere alafanechere force-pushed the augustin/01-05-airbyte-ci_re-introduce_mypy branch from 4de9510 to fe5650c Compare January 5, 2024 10:13
@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="fixing airbyte-ci regression"

@octavia-approvington
Copy link
Contributor

All in!!
all in baby

@octavia-approvington octavia-approvington merged commit f90d8db into master Jan 5, 2024
21 checks passed
@octavia-approvington octavia-approvington deleted the augustin/01-05-airbyte-ci_re-introduce_mypy branch January 5, 2024 10:42
Copy link

sentry-io bot commented Jan 5, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TransportError: Unexpected response from engine: Server error '502 Bad Gateway' for url 'http://127.0.0.1:33345/q... dagger.client._core in execute View Issue
  • ‼️ SessionError: Failed to start Dagger engine session: Command '/home/runner/.cache/dagger/dagger-0.9.5 session -... dagger._engine.session in get_connect_params View Issue
  • ‼️ AttributeError: 'PosixPath' object has no attribute 'endswith' pipelines.models.contexts.pipeline_context in g... View Issue

Did you find this useful? React with a 👍 or 👎

jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants