Airbyte-ci: Ensure we set the working directory earlier #34136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Oh! This makes more sense than hidden dir magic, or is that still something to watch out for? |
|
@evantahler Still technically an issue But only if we need to keep a hidden folder and ignore a path inside of it. |
evantahler
approved these changes
Jan 11, 2024
bnchrch
force-pushed
the
bnchrch/ci/fix-exclude
branch
from
2603af8
to
0a65e41
Compare
|
/approve-and-merge reason="format and test pass locally, but fail in due to a known issue with dagger" |
|
Lets do it! |
octavia-approvington
approved these changes
Jan 11, 2024
| @@ -0,0 +1,57 @@ | |||
| import logging | |||
There was a problem hiding this comment.
Missing license header 😄
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Globs we use for exclude were being evaluated before the working directory was set.
Leading to files that should be excluded appearing in dagger containers if the
airbyte-cicommmand was not run from rootQuick Solution
Hoist the function call higher
closes #34070