airbyte-lib: Enable tests

[flash1293]

Enables test for airbyte-lib (currently failing because the step gets stuck)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Jan 23, 2024 9:48am

[aaronsteers]

@flash1293, Thanks for creating. Just FYI, I added a dummy commit to trigger CI and hopefully repro the issue. 👍

[flash1293]

@alafanechere I did finish eventually - seems like what works on my local airbyte-ci doesn't work on Github CI... I would appreciate a look from your side how to reach the postgres docker container from within the test container.

I guess using dagger is one option. I used a "tunnel" to reach the container in the airbyte-ci integration tests as well: https://github.com/airbytehq/airbyte/pull/34111/files#diff-dbf7615b254775dc9fde6cd44e9b39cecdb7309661683244bc7eecac584a2870R74

However looking at how CAT is using it, it seems to pull in a lot of complexity to get it set up, I hope we can avoid that.

[flash1293]

@alafanechere On second thought, let me spend half an hour on it on Monday, maybe it's not as complex as I think

[alafanechere]

The tests are running correctly in CI now.
What I did:

• Provided an optional sidecar docker engine for airbyte-ci test: it's used for airbyte-lib tests. It fixes the connection problems to the test postgres instance. I could not figure why the local execution work. I believe it has something to do with how runner access docker themselves (through a sidecar pod with socket sharing). For simplicity and diminished reliance on the available docker host I prefer the dockerd as a dagger service approach.
• Slightly changed the provisioning logic of the postgres test container:
• Check container status before attempting connection
• Use the docker host as postgres host if it's set as an env var (when running inside dagger)

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ GithubException: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.gith... pipelines.helpers.github in update_commit_statu... View Issue

_{Did you find this useful? React with a 👍 or 👎}