Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-lib: Add publish action #34486

Merged
merged 19 commits into from
Jan 26, 2024
Merged

Conversation

flash1293
Copy link
Contributor

Add publish action for airbyte-lib to release on pypi

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2024 9:11am

@flash1293 flash1293 requested a review from a team January 25, 2024 08:09
Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment on lines +12 to +17
## Release

* In your PR:
* Bump the version in `pyproject.toml`
* Add a changelog entry to the table below
* Once the PR is merged, go to Github and trigger the `Publish AirbyteLib Manually` workflow. This will publish the new version to PyPI.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we get CI checks for missing changelog entries and/or unbumped versions?

It would be great if we could piggy-back on existing rails, if that's possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not really good existing guardrails as all places kind of do their own thing (connectors, airbyte-cdk). However, I added a basic check that a changelog entry is set for the current version.

I kept this simple deliberately so we have control over the publishing process in the first messy phase. We can add some automation later on if it makes sense (like auto-publishing as soon as the version changes on merge to master).

@flash1293 flash1293 enabled auto-merge (squash) January 26, 2024 09:14
@flash1293 flash1293 merged commit 8bdfd8b into master Jan 26, 2024
22 checks passed
@flash1293 flash1293 deleted the flash1293/airbyte-lib-publish2 branch January 26, 2024 09:20
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants