Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: fix inconsistent log path typing #34490

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 24, 2024

What

We have multiple code path mutating the dagger_log_path value in the context object.
One mutation assigns a string, other Path.
All function using this context value handle Path

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 5:27pm

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/01-24-airbyte-ci_fix_inconsistent_log_path_typing branch from a6c984e to 99dfd07 Compare January 24, 2024 17:27
@alafanechere alafanechere marked this pull request as ready for review January 24, 2024 17:28
@alafanechere alafanechere requested review from a team and flash1293 January 24, 2024 17:28
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged this into #34486 and it went through just fine, LGTM 👍

Thanks for the quick fix

@alafanechere alafanechere merged commit 9152ff8 into master Jan 25, 2024
27 of 28 checks passed
@alafanechere alafanechere deleted the augustin/01-24-airbyte-ci_fix_inconsistent_log_path_typing branch January 25, 2024 08:59
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants