Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK Destinations: DB Metadata calls cleanup #34533

Merged
merged 11 commits into from Jan 29, 2024
Merged

CDK Destinations: DB Metadata calls cleanup #34533

merged 11 commits into from Jan 29, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jan 25, 2024 •
edited

What

  • Cleaning up unsafe metadata calls

@vercel Vercel
Copy link

vercel bot commented Jan 25, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 11:35pm

@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Jan 25, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 25, 2024
@gisripa gisripa changed the title cdk/dbmetadata-cleanup CDK Destinations: DB Metadata calls cleanup Jan 25, 2024
@gisripa gisripa marked this pull request as ready for review January 25, 2024 17:58
edgao
edgao approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ the comment, super informative

@gisripa gisripa force-pushed the gireesh/01-25-cdk/dbmetadata-cleanup branch from 55f3d50 to ed4693e Compare January 25, 2024 23:02
@gisripa gisripa requested a review from a team as a code owner January 25, 2024 23:02
edgao
edgao approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicky comments about comments, otherwise lgtm

airbyte-cdk/java/airbyte-cdk/core/src/main/java/io/airbyte/cdk/db/jdbc/DefaultJdbcDatabase.java Outdated Show resolved Hide resolved
airbyte-cdk/java/airbyte-cdk/core/src/main/java/io/airbyte/cdk/db/jdbc/DefaultJdbcDatabase.java Outdated Show resolved Hide resolved
@gisripa gisripa force-pushed the gireesh/01-25-cdk/dbmetadata-cleanup branch from 9a96eb4 to 074d98e Compare January 26, 2024 18:04
@gisripa gisripa mentioned this pull request Jan 29, 2024
Merged
@gisripa gisripa force-pushed the gireesh/01-25-cdk/dbmetadata-cleanup branch from c857478 to 5f1c097 Compare January 29, 2024 20:54
@gisripa gisripa mentioned this pull request Jan 29, 2024
Merged
edgao
edgao approved these changes Jan 29, 2024
View reviewed changes
...yte-cdk/airbyte-commons/src/main/java/io/airbyte/commons/concurrency/CompletableFutures.java
* @return
* @param <T>
*/
public static <T> List<T> allOf(final List<CompletableFuture<T>> futures) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file needed? not in use afaict, and the implementation looks broken

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created for something else but removed the impl for now on this branch. I'll remove it later if not needed.

airbyte-cdk/java/airbyte-cdk/airbyte-commons/src/main/java/io/airbyte/commons/json/Jsons.java Outdated Show resolved Hide resolved
gisripa and others added 2 commits January 29, 2024 15:24
@gisripa
logistics
9e4c1e8
@gisripa @edgao
nit
493c436 
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
@gisripa
Copy link
Contributor Author

gisripa commented Jan 29, 2024 •
edited by github-actions bot

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/7703865875
✅ Successfully published Java CDK version=0.16.1!

@gisripa gisripa merged commit 0613ea5 into master Jan 29, 2024
19 checks passed
@gisripa gisripa deleted the gireesh/01-25-cdk/dbmetadata-cleanup branch January 29, 2024 23:48
gisripa added a commit that referenced this pull request Jan 30, 2024
@gisripa
Destination Redshift: Upgrade cdk to use dbMetadata closure function (#…
eea0d7b 
…34634)

## What
* See #34533
* Resolves airbytehq/alpha-beta-issues#2811
* Resolves airbytehq/alpha-beta-issues#2808 
* Resolves airbytehq/alpha-beta-issues#2804 
* Resolves airbytehq/alpha-beta-issues#2800
* Resolves airbytehq/alpha-beta-issues#2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
clnoll pushed a commit that referenced this pull request Jan 30, 2024
@gisripa @clnoll
Destination Redshift: Upgrade cdk to use dbMetadata closure function (#…
ade7d25 
…34634)

## What
* See #34533
* Resolves airbytehq/alpha-beta-issues#2811
* Resolves airbytehq/alpha-beta-issues#2808 
* Resolves airbytehq/alpha-beta-issues#2804 
* Resolves airbytehq/alpha-beta-issues#2800
* Resolves airbytehq/alpha-beta-issues#2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@gisripa @jatinyadav-cc
CDK Destinations: DB Metadata calls cleanup (airbytehq#34533)
64cc032 
## What
* Cleaning up unsafe metadata calls
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@gisripa @jatinyadav-cc
Destination Redshift: Upgrade cdk to use dbMetadata closure function (a…
18d4cde 
…irbytehq#34634)

## What
* See airbytehq#34533
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2811
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2808 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2804 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2800
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
CDK Destinations: DB Metadata calls cleanup (airbytehq#34533)
015d023 
## What
* Cleaning up unsafe metadata calls
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Destination Redshift: Upgrade cdk to use dbMetadata closure function (a…
2eeba06 
…irbytehq#34634)

## What
* See airbytehq#34533
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2811
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2808 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2804 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2800
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
CDK Destinations: DB Metadata calls cleanup (airbytehq#34533)
377a8f5 
## What
* Cleaning up unsafe metadata calls
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Destination Redshift: Upgrade cdk to use dbMetadata closure function (a…
8d13926 
…irbytehq#34634)

## What
* See airbytehq#34533
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2811
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2808 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2804 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2800
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
CDK Destinations: DB Metadata calls cleanup (airbytehq#34533)
b0bf0bc 
## What
* Cleaning up unsafe metadata calls
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Destination Redshift: Upgrade cdk to use dbMetadata closure function (a…
bd7edd6 
…irbytehq#34634)

## What
* See airbytehq#34533
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2811
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2808 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2804 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2800
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gisripa @edgao @octavia-squidington-iii