Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Redshift: Upgrade cdk to use dbMetadata closure function #34634

Merged
merged 2 commits into from Jan 30, 2024
Merged

Destination Redshift: Upgrade cdk to use dbMetadata closure function #34634

merged 2 commits into from Jan 30, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jan 29, 2024 •
edited

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 0:26am

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jan 29, 2024
@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Jan 29, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

This was referenced Jan 29, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited by gisripa

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@gisripa gisripa changed the title redshift/db-meta-cdk Destination Redshift: Upgrade cdk to use dbMetadata closure function Jan 29, 2024
@gisripa gisripa marked this pull request as ready for review January 29, 2024 20:59
@gisripa gisripa requested a review from a team as a code owner January 29, 2024 20:59
Base automatically changed from gireesh/01-25-cdk/dbmetadata-cleanup to master January 29, 2024 23:48
@gisripa gisripa force-pushed the gireesh/01-29-redshift/db-meta-cdk branch from bbf6296 to dfbf62a Compare January 29, 2024 23:54
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 30, 2024
@gisripa gisripa force-pushed the gireesh/01-29-redshift/db-meta-cdk branch from 78912f5 to 6e96674 Compare January 30, 2024 00:23
@gisripa gisripa merged commit eea0d7b into master Jan 30, 2024
23 of 24 checks passed
@gisripa gisripa deleted the gireesh/01-29-redshift/db-meta-cdk branch January 30, 2024 01:30
clnoll pushed a commit that referenced this pull request Jan 30, 2024
@gisripa @clnoll
Destination Redshift: Upgrade cdk to use dbMetadata closure function (#…
ade7d25 
…34634)

## What
* See #34533
* Resolves airbytehq/alpha-beta-issues#2811
* Resolves airbytehq/alpha-beta-issues#2808 
* Resolves airbytehq/alpha-beta-issues#2804 
* Resolves airbytehq/alpha-beta-issues#2800
* Resolves airbytehq/alpha-beta-issues#2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@gisripa @jatinyadav-cc
Destination Redshift: Upgrade cdk to use dbMetadata closure function (a…
18d4cde 
…irbytehq#34634)

## What
* See airbytehq#34533
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2811
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2808 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2804 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2800
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Destination Redshift: Upgrade cdk to use dbMetadata closure function (a…
2eeba06 
…irbytehq#34634)

## What
* See airbytehq#34533
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2811
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2808 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2804 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2800
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Destination Redshift: Upgrade cdk to use dbMetadata closure function (a…
8d13926 
…irbytehq#34634)

## What
* See airbytehq#34533
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2811
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2808 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2804 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2800
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Destination Redshift: Upgrade cdk to use dbMetadata closure function (a…
bd7edd6 
…irbytehq#34634)

## What
* See airbytehq#34533
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2811
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2808 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2804 
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2800
* Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2796

## How
* Execute dbMetadata ResultSet calls within a connection's lifecycle try-resource statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/destination/redshift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gisripa @edgao @octavia-squidington-iii