Destination redshift: Switch back to jooq execution; add e2e special characters test #34562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
edgao
force-pushed
the
edgao/dv2/special_characters
branch
from
1430936
to
c23c973
Compare
octavia-squidington-iii
removed
the
area/documentation
edgao
commented
Jan 26, 2024
...main/java/io/airbyte/integrations/destination/redshift/operations/RedshiftSqlOperations.java
Outdated
Show resolved
Hide resolved
gisripa
reviewed
Jan 29, 2024
| // but need to not escape bound strings. | ||
| // Instead, we force jooq to always inline params, | ||
| // and always call escapeStringLiteral() on the string values. | ||
| new Settings().withStatementType(StatementType.STATIC_STATEMENT)); |
There was a problem hiding this comment.
I was confused reading their docs. This will switch from prepared statement to inlined statement.
There is another setting .withParamType(ParamType.INLINED) which i think probably is what we are intending to do ? maybe the test will verify the expectation.
There was a problem hiding this comment.
nvm. just saw your resolved comment.
gisripa
approved these changes
Jan 29, 2024
|
/publish-java-cdk
|
octavia-squidington-iii
added
the
area/documentation
# Conflicts: # airbyte-cdk/java/airbyte-cdk/README.md # airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties # airbyte-integrations/connectors/destination-redshift/metadata.yaml # docs/integrations/destinations/redshift.md
|
/publish-java-cdk
|
edgao
force-pushed
the
edgao/dv2/special_characters
branch
from
8aefa29
to
e2e6523
Compare
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
…characters test (#34562)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
…characters test (#34562)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #34544.
Arguably these test cases belong in DATs, not T+D tests. At some point we should really reenable those :P
I'll submit two more PRs stacked on this one for updating the snowflake+bigquery expectedrecords files.