Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination snowflake: update test fixtures #34574

Merged
merged 9 commits into from Feb 9, 2024
Merged

Destination snowflake: update test fixtures #34574

merged 9 commits into from Feb 9, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jan 26, 2024

stacked on #34562

@edgao edgao requested a review from a team as a code owner January 26, 2024 18:57
@vercel Vercel
Copy link

vercel bot commented Jan 26, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 10:11pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited by edgao

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao edgao mentioned this pull request Jan 26, 2024
Merged
Base automatically changed from edgao/dv2/special_characters to master February 9, 2024 19:08
@edgao
Merge branch 'master' into edgao/dv2/snowflake_tests
5637175 
# Conflicts:
#	airbyte-cdk/java/airbyte-cdk/typing-deduping/src/testFixtures/java/io/airbyte/integrations/base/destination/typing_deduping/BaseTypingDedupingTest.java
#	airbyte-integrations/connectors/destination-redshift/src/main/java/io/airbyte/integrations/destination/redshift/operations/RedshiftSqlOperations.java
@edgao
logistics
fd9164a
@octavia-squidington-iii octavia-squidington-iii added area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/redshift labels Feb 9, 2024
@edgao edgao enabled auto-merge (squash) February 9, 2024 21:48
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Feb 9, 2024
@edgao edgao merged commit cb81cb4 into master Feb 9, 2024
22 of 23 checks passed
@edgao edgao deleted the edgao/dv2/snowflake_tests branch February 9, 2024 23:06
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
@edgao @xiaohansong
Destination snowflake: update test fixtures (#34574)
36df5eb
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@edgao @jatinyadav-cc
Destination snowflake: update test fixtures (airbytehq#34574)
d13b1a5
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@edgao @jatinyadav-cc
Destination snowflake: update test fixtures (airbytehq#34574)
e436442
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@edgao @jatinyadav-cc
Destination snowflake: update test fixtures (airbytehq#34574)
00ddd0c
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@edgao @jatinyadav-cc
Destination snowflake: update test fixtures (airbytehq#34574)
a70f540
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@edgao @xiaohansong
Destination snowflake: update test fixtures (#34574)
4c32917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gisripa gisripa gisripa approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/destination/redshift connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edgao @gisripa @octavia-squidington-iii