Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination redshift: Update to latest cdk #34613

Merged
merged 2 commits into from
May 6, 2024
Merged

Destination redshift: Update to latest cdk #34613

merged 2 commits into from
May 6, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jan 29, 2024 •
edited by gisripa
Loading

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 6:17pm

This was referenced Jan 29, 2024
Closed
Closed
Closed
Merged
@edgao Graphite App
Copy link
Contributor Author

edgao commented Jan 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

@edgao edgao mentioned this pull request Jan 29, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

This was referenced Jan 29, 2024
Closed
Closed
@edgao edgao changed the base branch from dv2/mysql_base to dv2/td_tests_allow_unsafe_cast January 29, 2024 18:14
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast branch from 9a43f6a to c57e51f Compare January 30, 2024 17:36
@edgao edgao force-pushed the dv2/mysql_redshift branch 2 times, most recently from e2a5843 to 3eec1d8 Compare January 30, 2024 22:02
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast branch 5 times, most recently from 70df4d0 to fa1d379 Compare February 1, 2024 18:17
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast branch 2 times, most recently from ff3bd11 to 38b5a37 Compare February 1, 2024 23:56
@octavia-squidington-iv octavia-squidington-iv requested review from a team April 29, 2024 15:13
@erohmensing erohmensing mentioned this pull request Apr 29, 2024
Closed
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast_2 branch from be524ad to be73530 Compare April 30, 2024 00:06
@edgao edgao requested a review from a team as a code owner April 30, 2024 00:06
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast_2 branch from be73530 to 55e7bf2 Compare April 30, 2024 15:14
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast_2 branch from 55e7bf2 to bdf95d2 Compare May 3, 2024 18:35
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast_2 branch from bdf95d2 to 1dfc87d Compare May 3, 2024 19:38
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast_2 branch 2 times, most recently from be36130 to 9bb61fe Compare May 3, 2024 20:07
Base automatically changed from dv2/td_tests_allow_unsafe_cast_2 to master May 3, 2024 20:29
@gisripa gisripa mentioned this pull request May 6, 2024
Closed
2 tasks
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 6, 2024
@gisripa gisripa merged commit d31f0dd into master May 6, 2024
36 checks passed
@gisripa gisripa deleted the dv2/mysql_redshift branch May 6, 2024 18:48
aasimsani pushed a commit to taxwire/airbyte that referenced this pull request May 6, 2024
@edgao @gisripa @aasimsani
Destination redshift: Update to latest cdk (airbytehq#34613)
3305e08 
Co-authored-by: Gireesh Sreepathi <gisripa@gmail.com>
@evantahler evantahler mentioned this pull request May 6, 2024
Closed
1 task
clnoll pushed a commit that referenced this pull request May 10, 2024
@edgao @gisripa @clnoll
Destination redshift: Update to latest cdk (#34613)
b8bae13 
Co-authored-by: Gireesh Sreepathi <gisripa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gisripa gisripa gisripa approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/redshift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edgao @gisripa @octavia-squidington-iii