Java CDK: DV2 tests have separate testcases for safe_cast #36935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
edgao
force-pushed
the
dv2/mysql_base_2
branch
2 times, most recently
from
ec6bfeb
to
6e1186b
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
55c1931
to
8236517
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
8236517
to
2965541
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
2965541
to
f40161c
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
f40161c
to
129aa86
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
129aa86
to
c0b31d2
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
c0b31d2
to
94a3dc0
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
94a3dc0
to
dd57516
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
dd57516
to
97d1fa3
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
97d1fa3
to
4e09b56
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
4e09b56
to
0548f6b
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
0548f6b
to
733ff64
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
7ae481a
to
2067931
Compare
This was referenced Apr 26, 2024
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
2067931
to
be524ad
Compare
.../io/airbyte/integrations/base/destination/typing_deduping/BaseSqlGeneratorIntegrationTest.kt
Outdated
Show resolved
Hide resolved
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
be524ad
to
be73530
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
be73530
to
55e7bf2
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
55e7bf2
to
bdf95d2
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
bdf95d2
to
1dfc87d
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
1dfc87d
to
be36130
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
be36130
to
9bb61fe
Compare
|
/publish-java-cdk
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported from #34616.
Mysql DV2 won't have a safe_cast implementation, so we need to update tests to support crashing on
CASTfailures.BaseSqlGeneratorIntegrationTest now requires implementations to specify whether they support safe casting, and its test cases have been updated to reflect this.
BaseTypingDedupingTest no longer exercises safe casting at all, under the assumption that the sqlgenerator test is sufficient coverage.
e.g. #34613 to update Redshift to the new fixtures. Other connectors should look pretty similar.