New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Stripe: Enable concurrency on incremental syncs for balance_transactions, events, files, file_links and shipping_rates #34619
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
8cff604
to
c53fff8
Compare
c53fff8
to
0443db0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @maxi297! Just one small question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor questions. good to 🚢
airbyte-integrations/connectors/source-stripe/source_stripe/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-stripe/source_stripe/source.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…transactions, files, file_links and shipping_rates (#34696)
What
Addresses #32057
How
Have
events
stream define a cursor when incrementalBlocked by:
#34605, #34625 and #34653#34675Note that this given #34605, the stream will end with two state messages if at least one slice is generated
🚨 User Impact 🚨
This is a non-breaking change as even though state would be granular if we were to emit states with a new format per slice, we are keeping the old format.
The main change in behavior is: