Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Stripe: Enable concurrency on incremental syncs for balance_transactions, events, files, file_links and shipping_rates #34619

Merged
merged 18 commits into from Feb 6, 2024

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Jan 29, 2024

What

Addresses #32057

How

Have events stream define a cursor when incremental

Blocked by: #34605, #34625 and #34653 #34675

Note that this given #34605, the stream will end with two state messages if at least one slice is generated

{"type": "LOG", "log": {"level": "INFO", "message": "Read 3649 records from events stream"}}
{"type": "LOG", "log": {"level": "INFO", "message": "Marking stream events as STOPPED"}}
{"type": "STATE", "state": {"type": "STREAM", "stream": {"stream_descriptor": {"name": "events"}, "stream_state": {"created": 1706643717}}, "data": {"events": {"created": 1706643717}}}}
{"type": "STATE", "state": {"type": "STREAM", "stream": {"stream_descriptor": {"name": "events"}, "stream_state": {"created": 1706643717}}, "data": {"events": {"created": 1706643717}}}}
{"type": "LOG", "log": {"level": "INFO", "message": "Finished syncing events"}}

🚨 User Impact 🚨

This is a non-breaking change as even though state would be granular if we were to emit states with a new format per slice, we are keeping the old format.

The main change in behavior is:

  • state value is not a max between latest_record_value and state_cursor_value anymore but uses the upper boundaries of the queries we performed. This allows for less processing for sparse streams of streams with small slice_range

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 8:53pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/stripe labels Jan 29, 2024
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@maxi297 maxi297 force-pushed the issue-32057/stripe-events-concurrent branch from 8cff604 to c53fff8 Compare January 29, 2024 18:28
@maxi297 maxi297 force-pushed the issue-32057/stripe-events-concurrent branch from c53fff8 to 0443db0 Compare January 29, 2024 19:45
@maxi297 maxi297 changed the title Issue 32057/stripe events concurrent ✨ Source Stripe: Events stream concurrent on incremental syncs Jan 30, 2024
@maxi297 maxi297 marked this pull request as ready for review January 30, 2024 17:30
@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 30, 2024 17:32
@maxi297
Copy link
Contributor Author

maxi297 commented Jan 30, 2024

The current CATs failure are caused by dccb2fa. A thread has been started here

Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @maxi297! Just one small question.

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor questions. good to 🚢

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maxi297 maxi297 merged commit a28aab9 into master Feb 6, 2024
26 checks passed
@maxi297 maxi297 deleted the issue-32057/stripe-events-concurrent branch February 6, 2024 13:18
@maxi297 maxi297 changed the title ✨ Source Stripe: Events stream concurrent on incremental syncs ✨ Source Stripe: Enable concurrency on incremental syncs for balance_transactions, events, files, file_links and shipping_rates Feb 6, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants