Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Stripe: Enable concurrency on incremental syncs for balance_transactions, files, file_links and shipping_rates #34696

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Jan 31, 2024

What

Addresses #32057

How

Have CreatedCursorIncrementalStripeStream classes define a cursor when incremental but exclude refunds as the cursor field will change after https://github.com/airbytehq/airbyte-internal-issues/issues/2450.

The stream was tested using a catalog with balance_transaction alone, files alone and both balance_transaction and files with and without state. file_links and shipping_rates were only reviewed manually (checking the API doc if there could be issue and validating by reading the code)

Blocked by: #34675 as CATs are failing because of an issue in a CAT test

Note that this given #34605, the stream will end with two state messages if at least one slice is generated (example with events but the same apply here)

{"type": "LOG", "log": {"level": "INFO", "message": "Read 3649 records from events stream"}}
{"type": "LOG", "log": {"level": "INFO", "message": "Marking stream events as STOPPED"}}
{"type": "STATE", "state": {"type": "STREAM", "stream": {"stream_descriptor": {"name": "events"}, "stream_state": {"created": 1706643717}}, "data": {"events": {"created": 1706643717}}}}
{"type": "STATE", "state": {"type": "STREAM", "stream": {"stream_descriptor": {"name": "events"}, "stream_state": {"created": 1706643717}}, "data": {"events": {"created": 1706643717}}}}
{"type": "LOG", "log": {"level": "INFO", "message": "Finished syncing events"}}

🚨 User Impact 🚨

This is a non-breaking change as even though state would be granular if we were to emit states with a new format per slice, we are keeping the old format

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 7:45pm

Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 1, 2024 14:40
@maxi297 maxi297 merged commit ff33a2a into issue-32057/stripe-events-concurrent Feb 5, 2024
10 of 17 checks passed
@maxi297 maxi297 deleted the issue-32057/stripe-created-cursor-incremental-concurrent branch February 5, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants