-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Stripe: Enable concurrency on incremental syncs for balance_transactions, files, file_links and shipping_rates #34696
Conversation
…es, file_links and shipping_rates
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!
…stripe-created-cursor-incremental-concurrent
ff33a2a
into
issue-32057/stripe-events-concurrent
What
Addresses #32057
How
Have
CreatedCursorIncrementalStripeStream
classes define a cursor when incremental but excluderefunds
as the cursor field will change after https://github.com/airbytehq/airbyte-internal-issues/issues/2450.The stream was tested using a catalog with
balance_transaction
alone,files
alone and bothbalance_transaction
andfiles
with and without state.file_links
andshipping_rates
were only reviewed manually (checking the API doc if there could be issue and validating by reading the code)Blocked by: #34675 as CATs are failing because of an issue in a CAT test
Note that this given #34605, the stream will end with two state messages if at least one slice is generated (example with
events
but the same apply here)🚨 User Impact 🚨
This is a non-breaking change as even though state would be granular if we were to emit states with a new format per slice, we are keeping the old format