Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Source Stripe: Enable concurrency on incremental syncs for balance_transactions, files, file_links and shipping_rates #34696

Merged
merged 3 commits into from
Feb 5, 2024
Merged

✨ Source Stripe: Enable concurrency on incremental syncs for balance_transactions, files, file_links and shipping_rates #34696

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
421e654
Enable concurrency on incremental syncs for balance_transactions, fil…
maxi297 Jan 31, 2024
548c5f2
skip failing CATs
maxi297 Feb 5, 2024
439d4e6
Merge branch 'issue-32057/stripe-events-concurrent' into issue-32057/…
maxi297 Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions airbyte-integrations/connectors/source-stripe/source_stripe/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import logging
import os
from datetime import datetime, timedelta
from datetime import timedelta
from typing import Any, List, Mapping, MutableMapping, Optional, Tuple

import pendulum
Expand Down Expand Up @@ -45,6 +45,10 @@
_MAX_CONCURRENCY = 20
_DEFAULT_CONCURRENCY = 10
_CACHE_DISABLED = os.environ.get("CACHE_DISABLED")
_REFUND_STREAM_NAME = "refunds"
_INCREMENTAL_CONCURRENCY_EXCLUSION = {
_REFUND_STREAM_NAME, # excluded because of the upcoming changes in terms of cursor https://github.com/airbytehq/airbyte/issues/34332
}
USE_CACHE = not _CACHE_DISABLED
STRIPE_TEST_ACCOUNT_PREFIX = "sk_test_"

Expand All @@ -54,6 +58,7 @@ class SourceStripe(ConcurrentSourceAdapter):
message_repository = InMemoryMessageRepository(entrypoint_logger.level)
_SLICE_BOUNDARY_FIELDS_BY_IMPLEMENTATION = {
Events: ("created[gte]", "created[lte]"),
CreatedCursorIncrementalStripeStream: ("created[gte]", "created[lte]"),
}

def __init__(self, catalog: Optional[ConfiguredAirbyteCatalog], config: Optional[Mapping[str, Any]], state: TState, **kwargs):
Expand Down Expand Up @@ -292,7 +297,7 @@ def streams(self, config: MutableMapping[str, Any]) -> List[Stream]:
# The Refunds stream does not utilize the Events API as it created issues with data loss during the incremental syncs.
# Therefore, we're using the regular API with the `created` cursor field. A bug has been filed with Stripe.
# See more at https://github.com/airbytehq/oncall/issues/3090, https://github.com/airbytehq/oncall/issues/3428
CreatedCursorIncrementalStripeStream(name="refunds", path="refunds", **incremental_args),
CreatedCursorIncrementalStripeStream(name=_REFUND_STREAM_NAME, path="refunds", **incremental_args),
UpdatedCursorIncrementalStripeStream(
name="payment_methods",
path="payment_methods",
Expand Down Expand Up @@ -523,7 +528,7 @@ def _to_concurrent(self, stream: Stream, fallback_start, state_manager: Connecto

state = state_manager.get_stream_state(stream.name, stream.namespace)
slice_boundary_fields = self._SLICE_BOUNDARY_FIELDS_BY_IMPLEMENTATION.get(type(stream))
if slice_boundary_fields:
if slice_boundary_fields and stream.name not in _INCREMENTAL_CONCURRENCY_EXCLUSION:
cursor_field = CursorField(stream.cursor_field) if isinstance(stream.cursor_field, str) else CursorField(stream.cursor_field[0])
converter = EpochValueConcurrentStreamStateConverter()
cursor = ConcurrentCursor(
Expand Down
Loading