Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-lib: Hidden documentation #34702

Merged
merged 48 commits into from
Feb 1, 2024
Merged

Conversation

flash1293
Copy link
Contributor

This is the first iteration of #33998

The documentation is available under using-airbyte/airbyte-lib/getting-started, but hidden in the side bar. On the connector pages, the config fields are shown, but airbyte-lib is not mentioned.

This is safe to merge in now so beta users have access to the documentation.

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:57pm

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I couldn't do a deep review, but I think it's okay to merge when ready.

@aaronsteers
Copy link
Collaborator

aaronsteers commented Jan 31, 2024

One issue I found - some connectors seem to be missing the "Reference" section. Specifically, I found that Amazon SQS seems to be missing it:

I don't think this should be a blocker to merge though. Some is better than none and we can follow-up as needed to debug anything missing. 🔎

@flash1293 flash1293 merged commit 2aa7327 into master Feb 1, 2024
19 checks passed
@flash1293 flash1293 deleted the flash1293/airbyte-lib-hidden branch February 1, 2024 10:43
@flash1293 flash1293 restored the flash1293/airbyte-lib-hidden branch February 1, 2024 10:44
@flash1293
Copy link
Contributor Author

@aaronsteers I found the root cause for the issue you found, will fix on a follow-up PR.

xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants