-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-lib: Hidden documentation #34702
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I couldn't do a deep review, but I think it's okay to merge when ready.
One issue I found - some connectors seem to be missing the "Reference" section. Specifically, I found that Amazon SQS seems to be missing it: I don't think this should be a blocker to merge though. Some is better than none and we can follow-up as needed to debug anything missing. 🔎 |
@aaronsteers I found the root cause for the issue you found, will fix on a follow-up PR. |
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
This is the first iteration of #33998
The documentation is available under
using-airbyte/airbyte-lib/getting-started
, but hidden in the side bar. On the connector pages, the config fields are shown, but airbyte-lib is not mentioned.This is safe to merge in now so beta users have access to the documentation.