-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Linnworks: Unblock CDK update #34717
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
bypass_reason: "No seed data in our sandbox account" | ||
- name: "stock_items" | ||
bypass_reason: "No seed data in our sandbox account" | ||
# Removing incremental tests for now as we have no seed data in our sandbox account for the two streams that support it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to flag this! This connector supports Incremental sync for two streams: processed_orders and processed_order_details. However, our sandbox contains no data for these streams and it doesn't seem we can simply add dummy data to it, so CAT Incremental tests have to be skipped for this connector at this time. Not ideal, but since it's a Community connector with very low traffic and the feature is at least unit tested, I've created an issue to track this for now and am hoping this won't be a blocker for this particular PR. (https://github.com/airbytehq/airbyte/issues/34743)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What
This PR is part of the larger project to republish older Community connectors in preparation for the sunsetting of legacy state. Source Linnworks currently fails to build due to a missing dependency
vcrpy
(link to issue). This PR unblocks it and resolves some existing CAT failures/bugs, so that it can be republished with the latest CDK version.How
vcrpy
to requirementsstock_locations
streamadditionalProperties
flag to true to resolve CAT failuresSuggested Reading Order
User Impact
No breaking changes, just bugfixes and some added fields to one schema.