Source Linnworks: re-enable in registry #35557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
askarpets
approved these changes
Feb 28, 2024
| poetry run source-linnworks spec | ||
| poetry run source-linnworks check --config secrets/config.json | ||
| poetry run source-linnworks discover --config secrets/config.json | ||
| poetry run source-linnworks read --config secrets/config.json --catalog sample_files/configured_catalog.json |
There was a problem hiding this comment.
Suggested change
| poetry run source-linnworks read --config secrets/config.json --catalog sample_files/configured_catalog.json | |
| poetry run source-linnworks read --config secrets/config.json --catalog integration_tests/configured_catalog.json |
There was a problem hiding this comment.
Good catch, thanks!
| python = "^3.9,<3.12" | ||
| airbyte-cdk = "^0.61.2" | ||
| vcrpy = "^6.0.0" | ||
| pendulum = "==2.1.2" |
There was a problem hiding this comment.
I believe pendulum is included as a part of airbyte-cdk, should it be removed?
There was a problem hiding this comment.
Didn't realize that, thanks for the heads up! Verified that it comes included with the CDK and updated the poetry/lock file
…tehq/airbyte into christo/linnworks-registry
ChristoGrab
requested review from
a team,
lazebnyi and
oustynova
as code owners
octavia-squidington-iii
added
CDK
ChristoGrab
removed
connectors/destination/mqtt
connectors/destination/mariadb-columnstore
connectors/destination/meilisearch
connectors/destination/pulsar
connectors/destination/scylla
connectors/destination/kinesis
connectors/destination/rockset
connectors/source/mongodb-v2
connectors/destination/firebolt
connectors/destination/databend
connectors/destination/rabbitmq
connectors/destination/scaffold-destination-python
connectors/destination/r2
connectors/destination/tidb
connectors/destination/doris
connectors/destination/yugabytedb
connectors/destination/redpanda
connectors/destination/exasol
connectors/destination/timeplus
connectors/destination/selectdb
connectors/destination/cumulio
connectors/destination/xata
connectors/destination/vertica
labels
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The Linnworks source connector was disabled in our registries as part of the initiative to sunset deprecated connectors still using legacy state. This PR adds it back to the registries, as it was recently published with an updated CDK version in #34717.
How