Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Facebook Marketing: Add missing fields #34845

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Feb 5, 2024

What

Add missing fields to a few streams.

@tolik0 tolik0 marked this pull request as ready for review February 5, 2024 13:21
Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 6:53am

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 5, 2024 13:22
@tolik0 tolik0 self-assigned this Feb 5, 2024
@tolik0 tolik0 force-pushed the tolik0/source-facebook-marketing/1-3-0-expected branch from d2224d8 to 8529831 Compare February 6, 2024 12:46
@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 7, 2024 06:54
@tolik0 tolik0 merged commit a960d9f into master Feb 7, 2024
23 of 24 checks passed
@tolik0 tolik0 deleted the tolik0/source-facebook-marketing/1-3-0-expected branch February 7, 2024 09:37
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
Co-authored-by: askarpets <anton.karpets@globallogic.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
Co-authored-by: askarpets <anton.karpets@globallogic.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: askarpets <anton.karpets@globallogic.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: askarpets <anton.karpets@globallogic.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: askarpets <anton.karpets@globallogic.com>
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
Co-authored-by: askarpets <anton.karpets@globallogic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants