🐛 Source Facebook Marketing: Add missing fields (airbytehq#34845)

Co-authored-by: askarpets <anton.karpets@globallogic.com>
ollionorg · Feb 26, 2024 · 1abe723 · 1abe723
1 parent de0d8a6
commit 1abe723
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 7 deletions.
diff --git a/airbyte-integrations/connectors/source-facebook-marketing/acceptance-test-config.yml b/airbyte-integrations/connectors/source-facebook-marketing/acceptance-test-config.yml
@@ -37,6 +37,8 @@ acceptance_tests:
           ad_creatives:
             - name: thumbnail_url
               bypass_reason: is changeable
+            - name: image_url
+              bypass_reason: is changeable
           images:
             - name: permalink_url
               bypass_reason: is changeable

diff --git a/...ntegrations/connectors/source-facebook-marketing/integration_tests/expected_records.jsonl b/...ntegrations/connectors/source-facebook-marketing/integration_tests/expected_records.jsonl
diff --git a/airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml b/airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
@@ -10,7 +10,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c
-  dockerImageTag: 1.3.0
+  dockerImageTag: 1.3.1
   dockerRepository: airbyte/source-facebook-marketing
   documentationUrl: https://docs.airbyte.com/integrations/sources/facebook-marketing
   githubIssueLabel: source-facebook-marketing

diff --git a/.../connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_creatives.json b/.../connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_creatives.json
@@ -60,6 +60,9 @@
             },
             "multi_share_end_card": {
               "type": ["null", "boolean"]
+            },
+            "is_click_to_message": {
+              "type": ["null", "boolean"]
             }
           }
         },
@@ -884,6 +887,9 @@
             },
             "show_multiple_images": {
               "type": ["null", "boolean"]
+            },
+            "use_flexible_image_aspect_ratio": {
+              "type": ["null", "boolean"]
             }
           },
           "type": ["null", "object"]
@@ -1099,6 +1105,17 @@
                     },
                     "type": ["null", "object"]
                   },
+                  "place_data": {
+                    "properties": {
+                      "location_source_id": {
+                        "type": ["null", "string"]
+                      },
+                      "type": {
+                        "type": ["null", "string"]
+                      }
+                    },
+                    "type": ["null", "object"]
+                  },
                   "caption": {
                     "type": ["null", "string"]
                   },
@@ -1123,6 +1140,9 @@
               },
               "type": ["null", "array"]
             },
+            "format_option": {
+              "type": ["null", "string"]
+            },
             "multi_share_optimized": {
               "type": ["null", "boolean"]
             },

diff --git a/...nectors/source-facebook-marketing/source_facebook_marketing/schemas/shared/targeting.json b/...nectors/source-facebook-marketing/source_facebook_marketing/schemas/shared/targeting.json
@@ -94,6 +94,15 @@
   },
   "type": ["null", "object"],
   "properties": {
+    "brand_safety_content_filter_levels": {
+      "type": ["null", "array"],
+      "items": {
+        "type": "string"
+      }
+    },
+    "targeting_relaxation_types": {
+      "type": ["null", "object"]
+    },
     "messenger_positions": {
       "type": ["null", "array"],
       "items": {

diff --git a/docs/integrations/sources/facebook-marketing.md b/docs/integrations/sources/facebook-marketing.md
@@ -203,7 +203,8 @@ The Facebook Marketing connector uses the `lookback_window` parameter to repeate
 
 | Version | Date       | Pull Request                                             | Subject                                                                                                                                                                                                                                                                                           |
 |:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| 1.3.0   | 2024-01-09  | [33538](https://github.com/airbytehq/airbyte/pull/33538) | Updated the `Ad Account ID(s)` property to support multiple IDs                                                                                                                                                                                                                                   |
+| 1.3.1   | 2024-02-05 | [34845](https://github.com/airbytehq/airbyte/pull/34845) | Add missing fields to schemas                                                                                                                                                                                                                                                                     |
+| 1.3.0   | 2024-01-09 | [33538](https://github.com/airbytehq/airbyte/pull/33538) | Updated the `Ad Account ID(s)` property to support multiple IDs                                                                                                                                                                                                                                   |
 | 1.2.3   | 2024-01-04 | [33934](https://github.com/airbytehq/airbyte/pull/33828) | Make ready for airbyte-lib                                                                                                                                                                                                                                                                        |
 | 1.2.2   | 2024-01-02 | [33828](https://github.com/airbytehq/airbyte/pull/33828) | Add insights job timeout to be an option, so a user can specify their own value                                                                                                                                                                                                                   |
 | 1.2.1   | 2023-11-22 | [32731](https://github.com/airbytehq/airbyte/pull/32731) | Removed validation that blocked personal ad accounts during `check`                                                                                                                                                                                                                               |