fix version of airbyte-cdk in Dockerfile pip install #34941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
girarda
approved these changes
Feb 7, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The .bumpversion.cfg file in
airbyte-cdk/pythonusually handles bumping the version of the airbyte-cdk used in thisRUN pip installline of the airbyte-cdk Dockerfile.However, the CDK version seems to have been manually bumped in this PR, and that line was missed in this manual change.
This caused that line to be left 1 version behind, and since then the
bumpversionscript has not modified that line on future version bump commits because it didn't match the current cdk version from that point forward.The effect of this is that this platform PR to update the CDK version used in the platform cannot succeed, as the old CDK version is still being used by the declarative source image, so builder connectors never pass the
checkcommand as their manifest version is larger than the CDK version in the declarative source image.How
This PR fixes the issue for future CDK version bumps by updating the version in that line to match the current version.
It is unclear if this change alone will fix the platform PR linked above - that may require a republishing of the airbyte CDK image.