AirbyteLib: Improved progress print, especially in the terminal #34973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive view until it is needed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ove-progress-messaging
aaronsteers
changed the title
bindipankhudi
approved these changes
Feb 7, 2024
|
|
||
| # This is a dummy secret, just to test functionality. | ||
| DUMMY_SECRET = ab.get_secret("DUMMY_SECRET") |
There was a problem hiding this comment.
this does not seem to be used anywhere.
There was a problem hiding this comment.
Yes, that's correct. It's literally just there to make sure our progress printer isn't conflicting with our ability to take input from the user, which was previously an issue.
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves some problems with the rich live view, and takes a more formal approach to (1) selecting the best redering option, and (2) creating the "live view" rendering elements only when they are needed.
This also adds friendly prints where otherwise we didn't give any feedback to the user about what was happening.
Lastly, I've updated the "run_github.py" to use a reasonably sized repo, and it runs now in <1 minute.
(Set to auto-merge on approval and passing tests.)