Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix msssql tests take 3 #35121

Closed
wants to merge 1 commit into from
Closed

fix msssql tests take 3 #35121

wants to merge 1 commit into from

Conversation

stephane-airbyte
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Feb 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 9:19am

@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Feb 10, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Feb 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 504cc01 to b79379d Compare February 10, 2024 01:31
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 10, 2024
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from b79379d to 6febfeb Compare February 10, 2024 03:18
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 10, 2024
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 6febfeb to 5e4fb75 Compare February 10, 2024 07:59
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Feb 10, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch 3 times, most recently from 979417b to d731848 Compare February 10, 2024 09:10
This was referenced Feb 10, 2024
Closed
Closed
Closed
@stephane-airbyte stephane-airbyte changed the base branch from master to stephane/02-13-write_logs_to_file_in_addition_to_stdout_when_running_java_connector_tests February 13, 2024 19:20
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from d731848 to 84bf501 Compare February 13, 2024 19:20
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 13, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 84bf501 to 4317dea Compare February 13, 2024 19:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-13-write_logs_to_file_in_addition_to_stdout_when_running_java_connector_tests branch 7 times, most recently from 7d651af to 7cd0a70 Compare February 14, 2024 01:00
Base automatically changed from stephane/02-13-write_logs_to_file_in_addition_to_stdout_when_running_java_connector_tests to master February 14, 2024 14:06
@stephane-airbyte stephane-airbyte changed the base branch from master to stephane/02-13-make_airbyte-ci_pass_a_parameter_to_the_java_connectors_to_the_location_of_the_logs February 16, 2024 00:44
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 3963f70 to dda9404 Compare February 22, 2024 21:40
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-improve_logging_in_MsSQLTestDatabase branch from b51840c to 14e9791 Compare February 22, 2024 22:22
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from dda9404 to de56526 Compare February 22, 2024 22:22
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-improve_logging_in_MsSQLTestDatabase branch from 14e9791 to d608699 Compare February 22, 2024 22:47
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from de56526 to fb071d9 Compare February 22, 2024 22:47
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-improve_logging_in_MsSQLTestDatabase branch from d608699 to 6d2cc0e Compare February 22, 2024 23:50
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from fb071d9 to b643836 Compare February 22, 2024 23:50
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-improve_logging_in_MsSQLTestDatabase branch from 6d2cc0e to b6d0e07 Compare February 23, 2024 00:08
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from b643836 to d56effa Compare February 23, 2024 00:08
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-improve_logging_in_MsSQLTestDatabase branch from b6d0e07 to ed67f53 Compare February 23, 2024 22:55
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from d56effa to d260b19 Compare February 23, 2024 22:55
This was referenced Feb 24, 2024
Closed
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-improve_logging_in_MsSQLTestDatabase branch from ed67f53 to 33ec41d Compare February 24, 2024 03:24
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from d260b19 to a07e478 Compare February 24, 2024 03:24
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 24, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-improve_logging_in_MsSQLTestDatabase branch from 33ec41d to 5dd97b2 Compare February 24, 2024 09:02
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 24, 2024
Merged
@stephane-airbyte stephane-airbyte changed the base branch from stephane/02-21-improve_logging_in_MsSQLTestDatabase to stephane/02-21-move_some_very_verbose_log_messages_to_info February 24, 2024 09:05
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from a07e478 to 7bf7979 Compare February 24, 2024 09:05
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-move_some_very_verbose_log_messages_to_info branch from d5d7035 to 2b92c25 Compare February 24, 2024 09:18
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 7bf7979 to 2503621 Compare February 24, 2024 09:18
This was referenced Feb 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/source/mssql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephane-airbyte @octavia-squidington-iii