✨ Source Sentry: migrate to low code #35755

darynaishchenko · 2024-03-01T17:16:40Z

What

resolved: https://github.com/airbytehq/airbyte-internal-issues/issues/6632
Migrate Source Sentry to Low Code.

How

Updated manifest.yaml with declared in low code streams. Added integration tests for empty streams Issues and Events.

🚨 User Impact 🚨

No breaking changes.

Sentry low code migration qa

vercel · 2024-03-01T17:16:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 27, 2024 5:20pm

girarda · 2024-03-01T18:29:59Z

airbyte-integrations/connectors/source-sentry/metadata.yaml

+  releases:
+    breakingChanges:
+      1.0.0:
+        message: "Source Sentry has been migrated to YAML Declarative Source."


why is this a breaking change?

+1. Seems like schemas have not changed?

@girarda @natikgadzhi yes, actually this is not breaking change and low-code version of the connector is compatible with the previous one. According to the migration to low-code guide I thought we migrate all connectors to low-code as breaking change. If it's not I can remove breaking change docs from the pr.

If the config, the state, and the schema are compatible, we shouldn't mark this as a breaking change. CC @katmarkham

natikgadzhi

Thank you @darynaishchenko! 🎉

My only question is the same as from @girarda — not sure if the schema changes mandate this to be a breaking change.

@clnoll, should we try and use the regression testing tool on this?

natikgadzhi · 2024-03-03T17:28:24Z

airbyte-integrations/connectors/source-sentry/.coveragerc

@@ -1,3 +1,3 @@
 [run]
-omit = 
+omit =
    source_sentry/run.py


Some folks had to also add main.py and __init__.py, but if the coverage is hit, I guess we're okay /shrug

Note to self: this file should be in the template for new connectors

natikgadzhi · 2024-03-03T17:28:50Z

airbyte-integrations/connectors/source-sentry/acceptance-test-config.yml

@@ -4,7 +4,7 @@ acceptance_tests:
      - config_path: secrets/config.json
        empty_streams:
          - name: issues
-            bypass_reason: "Project sssues are not being returned by the Sentry API."
+            bypass_reason: "Project issues are not being returned by the Sentry API."


Thank you for catching these 👏

natikgadzhi · 2024-03-03T17:30:07Z

airbyte-integrations/connectors/source-sentry/source_sentry/manifest.yaml

@@ -1,105 +1,149 @@
-version: "0.29.0"
+version: 0.57.0


I'm a bit confused by this, and I see this in a couple PRs (another one is #35776). Should manifest.version be the minimal version of the CDK that can run this, or should it be the version of the connector? If it's the connector version, should this be 1.0.0?

This version was added by the connector builder, this is version of cdk, I'm confused with this too, because poetry lock declares another version of cdk. So it looks like I need to update version in manifest.

natikgadzhi · 2024-03-03T17:31:14Z

airbyte-integrations/connectors/source-sentry/source_sentry/manifest.yaml

    page_token_option:
      type: RequestOption
-      inject_into: "request_parameter"
-      field_name: "cursor"
+      inject_into: request_parameter


Out of curiosity: what formatting tool are you using? I want to make sure we will setup our tooling so formatting is consistent across the team

I used manual + IDE + airbyte-ci formatting. page_token_option: was added and formatted by connector builder.

natikgadzhi · 2024-03-03T17:31:58Z

airbyte-integrations/connectors/source-sentry/source_sentry/source.py

-            Projects(**stream_args),
-            Releases(**project_stream_args),
-        ]
+class SourceSentry(YamlDeclarativeSource):


Nice that all streams could move to declarative. 👏

Yes, one thing that is different in new and old version is state calculation. Now states equals date of sync, previously it was date of recent record. But for this streams it can be used as dateCreated and lastSeen values can not be updated manually, so date of cursor can not be changed after sync.

natikgadzhi · 2024-03-03T17:32:31Z

airbyte-integrations/connectors/source-sentry/metadata.yaml

+  releases:
+    breakingChanges:
+      1.0.0:
+        message: "Source Sentry has been migrated to YAML Declarative Source."


+1. Seems like schemas have not changed?

maxi297

Two concerns i'd like to address before approving (the rest is nit):

the API call change for issues
the semi-incremental thing for releases and projects

airbyte-integrations/connectors/source-sentry/source_sentry/manifest.yaml

maxi297

Awesome work @darynaishchenko ! 🚢

artem1205 · 2024-03-12T17:22:23Z

airbyte-integrations/connectors/source-sentry/unit_tests/integration/test_issues_stream.py

+
+    @HttpMocker()
+    def test_read(self, http_mocker: HttpMocker):
+        response = [


nit: please move responses to unit_tests/resource/http/response

darynaishchenko added 14 commits March 1, 2024 18:13

updated readme

1f8e874

updated manifest.yaml

a42b51e

updated stream schemas with new fields

6528502

updated source.py with YamlDeclarativeSource

624d0a7

deleted streams.py

0dec349

deleted test_stream.py

30dbabb

updated test_source.py

12ce18b

added test for empty streams

f16e01a

updated cat config

a7c4daf

bump version

85cac39

omit run.py

4bd818e

updated cat config

5018802

format fix

7ad6bfa

Merge branch 'master' into daryna/source-sentry/migrate-to-low-code

8845483

darynaishchenko self-assigned this Mar 1, 2024

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sentry labels Mar 1, 2024

updated changelog

21bdf35

octavia-squidington-iv requested review from a team March 1, 2024 17:18

vercel bot deployed to Preview March 1, 2024 17:24 View deployment

added breaking change docs

8fc17cc

octavia-squidington-iv requested a review from a team March 1, 2024 17:33

vercel bot deployed to Preview March 1, 2024 17:36 View deployment

format fix

86f470d

girarda reviewed Mar 1, 2024

View reviewed changes

octavia-squidington-iv requested a review from a team March 1, 2024 18:31

natikgadzhi reviewed Mar 3, 2024

View reviewed changes

darynaishchenko requested a review from natikgadzhi March 6, 2024 18:10

vercel bot deployed to Preview March 6, 2024 18:13 View deployment

darynaishchenko requested a review from maxi297 March 7, 2024 10:11

Merge branch 'master' into daryna/source-sentry/migrate-to-low-code

79dc903

vercel bot deployed to Preview March 7, 2024 10:16 View deployment

maxi297 reviewed Mar 7, 2024

View reviewed changes

octavia-squidington-iv requested a review from a team March 7, 2024 16:02

darynaishchenko added 2 commits March 8, 2024 14:57

remove stats from issues request

587a54d

updated test_streams.py

7fb0384

darynaishchenko requested a review from maxi297 March 8, 2024 13:15

maxi297 approved these changes Mar 8, 2024

View reviewed changes

darynaishchenko removed the request for review from a team March 8, 2024 14:02

lazebnyi approved these changes Mar 11, 2024

View reviewed changes

artem1205 approved these changes Mar 12, 2024

View reviewed changes

darynaishchenko and others added 3 commits March 14, 2024 19:13

updated dependecies

89c13ca

moved response for integration tests to files

c8c4ed5

Merge branch 'master' into daryna/source-sentry/migrate-to-low-code

fc40d38

vercel bot deployed to Preview March 14, 2024 17:40 View deployment

pin airbyte-cdk to ^0

3db0f74

darynaishchenko requested a review from brianjlai March 21, 2024 17:59

darynaishchenko and others added 2 commits March 25, 2024 13:58

updated tag in metadata

e5b9207

Merge branch 'master' into daryna/source-sentry/migrate-to-low-code

5f8bec7

vercel bot deployed to Preview March 25, 2024 12:47 View deployment

revert tags

980c32b

darynaishchenko added the low-code-migration This connector has been migrated to the low-code CDK label Mar 25, 2024

Merge branch 'master' into daryna/source-sentry/migrate-to-low-code

2bdb936

vercel bot deployed to Preview March 27, 2024 17:20 View deployment

lazebnyi merged commit ca6d722 into master Mar 28, 2024
30 checks passed

lazebnyi deleted the daryna/source-sentry/migrate-to-low-code branch March 28, 2024 20:10

nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024

✨ Source Sentry: migrate to low code (airbytehq#35755)

32d56fc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Source Sentry: migrate to low code #35755

✨ Source Sentry: migrate to low code #35755

darynaishchenko commented Mar 1, 2024 •

edited

Loading

vercel bot commented Mar 1, 2024 •

edited

Loading

girarda Mar 1, 2024

natikgadzhi Mar 3, 2024

darynaishchenko Mar 4, 2024

girarda Mar 19, 2024

natikgadzhi left a comment

natikgadzhi Mar 3, 2024

natikgadzhi Mar 3, 2024

natikgadzhi Mar 3, 2024

natikgadzhi Mar 3, 2024

darynaishchenko Mar 4, 2024

natikgadzhi Mar 3, 2024

darynaishchenko Mar 4, 2024

natikgadzhi Mar 3, 2024

darynaishchenko Mar 4, 2024

natikgadzhi Mar 3, 2024

maxi297 left a comment

maxi297 left a comment

artem1205 Mar 12, 2024

darynaishchenko Mar 14, 2024

✨ Source Sentry: migrate to low code #35755

✨ Source Sentry: migrate to low code #35755

Conversation

darynaishchenko commented Mar 1, 2024 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

vercel bot commented Mar 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

natikgadzhi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxi297 left a comment

Choose a reason for hiding this comment

maxi297 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darynaishchenko commented Mar 1, 2024 •

edited

Loading

vercel bot commented Mar 1, 2024 •

edited

Loading