-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Sentry: migrate to low code #35755
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1f8e874
updated readme
darynaishchenko a42b51e
updated manifest.yaml
darynaishchenko 6528502
updated stream schemas with new fields
darynaishchenko 624d0a7
updated source.py with YamlDeclarativeSource
darynaishchenko 0dec349
deleted streams.py
darynaishchenko 30dbabb
deleted test_stream.py
darynaishchenko 12ce18b
updated test_source.py
darynaishchenko f16e01a
added test for empty streams
darynaishchenko a7c4daf
updated cat config
darynaishchenko 85cac39
bump version
darynaishchenko 4bd818e
omit run.py
darynaishchenko 5018802
updated cat config
darynaishchenko 7ad6bfa
format fix
darynaishchenko 8845483
Merge branch 'master' into daryna/source-sentry/migrate-to-low-code
darynaishchenko 21bdf35
updated changelog
darynaishchenko 8fc17cc
added breaking change docs
darynaishchenko 86f470d
format fix
darynaishchenko 97f6843
updated connector version
darynaishchenko 67e8c9a
refactored manifest.yaml
darynaishchenko 00a0d57
updated tests
darynaishchenko 457bc26
delete migration docs
darynaishchenko 79dc903
Merge branch 'master' into daryna/source-sentry/migrate-to-low-code
darynaishchenko 587a54d
remove stats from issues request
darynaishchenko 7fb0384
updated test_streams.py
darynaishchenko 89c13ca
updated dependecies
darynaishchenko c8c4ed5
moved response for integration tests to files
darynaishchenko fc40d38
Merge branch 'master' into daryna/source-sentry/migrate-to-low-code
darynaishchenko 3db0f74
pin airbyte-cdk to ^0
darynaishchenko e5b9207
updated tag in metadata
darynaishchenko 5f8bec7
Merge branch 'master' into daryna/source-sentry/migrate-to-low-code
darynaishchenko 980c32b
revert tags
darynaishchenko 2bdb936
Merge branch 'master' into daryna/source-sentry/migrate-to-low-code
darynaishchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[run] | ||
omit = | ||
omit = | ||
source_sentry/run.py | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ acceptance_tests: | |
- config_path: secrets/config.json | ||
empty_streams: | ||
- name: issues | ||
bypass_reason: "Project sssues are not being returned by the Sentry API." | ||
bypass_reason: "Project issues are not being returned by the Sentry API." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for catching these 👏 |
||
- name: events | ||
bypass_reason: "No event records exist for the test project." | ||
timeout_seconds: 1200 | ||
|
@@ -22,10 +22,10 @@ acceptance_tests: | |
full_refresh: | ||
tests: | ||
- config_path: secrets/config.json | ||
configured_catalog_path: integration_tests/configured_catalog.json | ||
configured_catalog_path: integration_tests/configured_catalog_full_refresh.json | ||
# test 403 exception is not breaking the sync | ||
- config_path: secrets/config_limited_scopes.json | ||
configured_catalog_path: integration_tests/configured_catalog.json | ||
configured_catalog_path: integration_tests/configured_catalog_full_refresh.json | ||
incremental: | ||
tests: | ||
- config_path: secrets/config.json | ||
|
31 changes: 31 additions & 0 deletions
31
...egrations/connectors/source-sentry/integration_tests/configured_catalog_full_refresh.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
{ | ||
"streams": [ | ||
{ | ||
"sync_mode": "full_refresh", | ||
"destination_sync_mode": "overwrite", | ||
"stream": { | ||
"name": "project_detail", | ||
"json_schema": {}, | ||
"supported_sync_modes": ["full_refresh"] | ||
} | ||
}, | ||
{ | ||
"sync_mode": "incremental", | ||
"destination_sync_mode": "append_dedup", | ||
"stream": { | ||
"name": "projects", | ||
"json_schema": {}, | ||
"supported_sync_modes": ["full_refresh", "incremental"] | ||
} | ||
}, | ||
{ | ||
"sync_mode": "incremental", | ||
"destination_sync_mode": "append_dedup", | ||
"stream": { | ||
"name": "releases", | ||
"json_schema": {}, | ||
"supported_sync_modes": ["full_refresh", "incremental"] | ||
} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 19 additions & 22 deletions
41
airbyte-integrations/connectors/source-sentry/poetry.lock
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some folks had to also add
main.py
and__init__.py
, but if the coverage is hit, I guess we're okay /shrugThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: this file should be in the template for new connectors