Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Sentry: migrate to low code #35755

Merged
merged 32 commits into from
Mar 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
1f8e874
updated readme
darynaishchenko Mar 1, 2024
a42b51e
updated manifest.yaml
darynaishchenko Mar 1, 2024
6528502
updated stream schemas with new fields
darynaishchenko Mar 1, 2024
624d0a7
updated source.py with YamlDeclarativeSource
darynaishchenko Mar 1, 2024
0dec349
deleted streams.py
darynaishchenko Mar 1, 2024
30dbabb
deleted test_stream.py
darynaishchenko Mar 1, 2024
12ce18b
updated test_source.py
darynaishchenko Mar 1, 2024
f16e01a
added test for empty streams
darynaishchenko Mar 1, 2024
a7c4daf
updated cat config
darynaishchenko Mar 1, 2024
85cac39
bump version
darynaishchenko Mar 1, 2024
4bd818e
omit run.py
darynaishchenko Mar 1, 2024
5018802
updated cat config
darynaishchenko Mar 1, 2024
7ad6bfa
format fix
darynaishchenko Mar 1, 2024
8845483
Merge branch 'master' into daryna/source-sentry/migrate-to-low-code
darynaishchenko Mar 1, 2024
21bdf35
updated changelog
darynaishchenko Mar 1, 2024
8fc17cc
added breaking change docs
darynaishchenko Mar 1, 2024
86f470d
format fix
darynaishchenko Mar 1, 2024
97f6843
updated connector version
darynaishchenko Mar 6, 2024
67e8c9a
refactored manifest.yaml
darynaishchenko Mar 6, 2024
00a0d57
updated tests
darynaishchenko Mar 6, 2024
457bc26
delete migration docs
darynaishchenko Mar 6, 2024
79dc903
Merge branch 'master' into daryna/source-sentry/migrate-to-low-code
darynaishchenko Mar 7, 2024
587a54d
remove stats from issues request
darynaishchenko Mar 8, 2024
7fb0384
updated test_streams.py
darynaishchenko Mar 8, 2024
89c13ca
updated dependecies
darynaishchenko Mar 14, 2024
c8c4ed5
moved response for integration tests to files
darynaishchenko Mar 14, 2024
fc40d38
Merge branch 'master' into daryna/source-sentry/migrate-to-low-code
darynaishchenko Mar 14, 2024
3db0f74
pin airbyte-cdk to ^0
darynaishchenko Mar 21, 2024
e5b9207
updated tag in metadata
darynaishchenko Mar 25, 2024
5f8bec7
Merge branch 'master' into daryna/source-sentry/migrate-to-low-code
darynaishchenko Mar 25, 2024
980c32b
revert tags
darynaishchenko Mar 25, 2024
2bdb936
Merge branch 'master' into daryna/source-sentry/migrate-to-low-code
darynaishchenko Mar 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-sentry/.coveragerc
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[run]
omit =
omit =
source_sentry/run.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some folks had to also add main.py and __init__.py, but if the coverage is hit, I guess we're okay /shrug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: this file should be in the template for new connectors

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-sentry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ See `sample_files/sample_config.json` for a sample config file.
poetry run source-sentry spec
poetry run source-sentry check --config secrets/config.json
poetry run source-sentry discover --config secrets/config.json
poetry run source-sentry read --config secrets/config.json --catalog sample_files/configured_catalog.json
poetry run source-sentry read --config secrets/config.json --catalog integration_tests/configured_catalog.json
```

### Running unit tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ acceptance_tests:
- config_path: secrets/config.json
empty_streams:
- name: issues
bypass_reason: "Project sssues are not being returned by the Sentry API."
bypass_reason: "Project issues are not being returned by the Sentry API."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching these 👏

- name: events
bypass_reason: "No event records exist for the test project."
timeout_seconds: 1200
Expand All @@ -22,10 +22,10 @@ acceptance_tests:
full_refresh:
tests:
- config_path: secrets/config.json
configured_catalog_path: integration_tests/configured_catalog.json
configured_catalog_path: integration_tests/configured_catalog_full_refresh.json
# test 403 exception is not breaking the sync
- config_path: secrets/config_limited_scopes.json
configured_catalog_path: integration_tests/configured_catalog.json
configured_catalog_path: integration_tests/configured_catalog_full_refresh.json
incremental:
tests:
- config_path: secrets/config.json
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"streams": [
{
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite",
"stream": {
"name": "project_detail",
"json_schema": {},
"supported_sync_modes": ["full_refresh"]
}
},
{
"sync_mode": "incremental",
"destination_sync_mode": "append_dedup",
"stream": {
"name": "projects",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
}
},
{
"sync_mode": "incremental",
"destination_sync_mode": "append_dedup",
"stream": {
"name": "releases",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
}
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: cdaf146a-9b75-49fd-9dd2-9d64a0bb4781
dockerImageTag: 0.4.2
dockerImageTag: 0.5.0
dockerRepository: airbyte/source-sentry
documentationUrl: https://docs.airbyte.com/integrations/sources/sentry
githubIssueLabel: source-sentry
Expand Down
41 changes: 19 additions & 22 deletions airbyte-integrations/connectors/source-sentry/poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "0.4.2"
version = "0.5.0"
name = "source-sentry"
description = "Source implementation for Sentry."
authors = [ "Airbyte <contact@airbyte.io>",]
Expand Down
Loading
Loading