Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Recurly: Unarchive and release as 1.0 #35763

Merged
merged 4 commits into from Mar 4, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Mar 1, 2024

What

Brings source Recurly back from the archived-connectors repo and into the catalog!

How

  • Moved connector code back to our repo
  • Re-enabled in metadata registries
  • Changed version to1.0.0 and added breaking change metadata: I had originally shipped this version as a non-breaking update. However, we are seeing instances of syncs failing on the new version due to an error detecting schema changes:

image

Given that:

  • I have not been able to reproduce any errors when creating a new connection
  • All tests are passing consistently in airbyte-ci
  • There are connections successfully syncing with the updated version

I believe the issue lies in the schema changes introduced being backward-incompatible. In that case, the problem should be resolved by having our users go through the usual breaking change migration process and refreshing their schemas/resetting data before resuming syncs.

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 10:34pm

message:
Version 1.0.0 introduces a number of schema updates to the Recurly connector.
To ensure a smooth upgrade, please refresh your schemas and reset your data before resuming syncs.
upgradeDeadline: "2024-03-05"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this date as a placeholder since March 5th was the stated deadline for using the sunsetting connectors. Let me know if this should be changed!

@ChristoGrab ChristoGrab merged commit 62abce9 into master Mar 4, 2024
33 checks passed
@ChristoGrab ChristoGrab deleted the christo/unarchive-recurly branch March 4, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/recurly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants