Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive connectors already hidden with legacy state #35752

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Archive connectors already hidden with legacy state #35752

merged 2 commits into from
Mar 1, 2024

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Mar 1, 2024 •
edited
Loading

These 8 sources are hidden today via LaunchDarkly because they have legacy state

Screenshot 2024-03-01 at 8 28 10 AM 
cd42861b-01fc-4658-a8ab-5d11d0510f01 - airbyte/source-recurly
af123bf-0aaf-4e0d-9784-cb497f23741a - airbyte/source-appstore-singer
8d7ef552-2c0f-11ec-8d3d-0242ac130003 - airbyte/source-search-metrics
1356e1d9-977f-4057-ad4b-65f25329cf61 - airbyte/source-dv-360
3dc3037c-5ce8-4661-adc2-f7a9e3c5ece5 - airbyte/source-zuora
0541b2cd-2367-4986-b5f1-b79ff55439e4 -  airbyte/source-courier
cd06e646-31bf-4dc8-af48-cbc6530fcad3 - airbyte/source-kustomer-singer
f00d2cf4-3c28-499a-ba93-b50b6f26359e - airbyte/source-talkdesk-explore

However, the LaunchDarkly feature flag only hides connectors from the new source page, but doesn't indicate that it can't be used any more from the docs. This PR uses our new Archived tooling to formally remove the connector.

Note: source-linworks is also hidden by the feature flag, but we don't want to archive that connector

TODO

  • PR 1: Set archived=true and remove the connector from the registires
  • PR 2: Remove the connector's code and move to https://github.com/airbytehq/connector-archive
  • Remove the old Hide Legacy State Connectors LaunchDarkly feature flag - it won't be needed any more after PR 1

@vercel Vercel
Copy link

vercel bot commented Mar 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 5:59pm

evantahler
evantahler commented Mar 1, 2024
View reviewed changes
airbyte-integrations/connectors/source-linnworks/metadata.yaml Outdated
Comment on lines 19 to 21
enabled: true
enabled: false
oss:
enabled: true
enabled: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of note - Linworks was hidden but still in the OSS and Cloud registries. I think this was a mistake, given the LaunchDarkly feature flag?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evantahler I believe @ChristoGrab updated this connector to the latest CDK so it does not use legacy state.
I think you can revert your changes on this metadata.yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#35557

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'll leave Linworks in. It's currently hidden by the feature flag... so you might want to change that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristoGrab can you remove linnworks feature flag if you think it can now work on Cloud?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dfefdd8

@evantahler evantahler marked this pull request as ready for review March 1, 2024 16:35
@evantahler
Copy link
Contributor Author

/approve-and-merge reason="archive some connectors"

@octavia-approvington
Copy link
Contributor

Our work here is done
done

@octavia-approvington octavia-approvington merged commit 0f000b9 into master Mar 1, 2024
28 of 29 checks passed
@octavia-approvington octavia-approvington deleted the evan/archive-legacy-state-connectors branch March 1, 2024 18:01
@evantahler evantahler mentioned this pull request Mar 1, 2024
Merged
@natikgadzhi
Copy link
Contributor

Hmm, I think @ChristoGrab just updated Recurly, no? Should we consider un-archiving it and making it available? /cc @katmarkham

@ChristoGrab
Copy link
Contributor

Working on it now 👍: #35763

@evantahler evantahler mentioned this pull request Mar 5, 2024
Merged
xiaohansong pushed a commit that referenced this pull request Mar 7, 2024
@evantahler @xiaohansong
Archive connectors already hidden with legacy state (#35752)
88c7d13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alafanechere alafanechere alafanechere approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

@natikgadzhi natikgadzhi Awaiting requested review from natikgadzhi

@erohmensing erohmensing Awaiting requested review from erohmensing

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/appstore-singer connectors/source/courier connectors/source/dv-360 connectors/source/kustomer-singer connectors/source/linnworks connectors/source/recurly connectors/source/search-metrics connectors/source/talkdesk-explore connectors/source/zuora
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@evantahler @octavia-approvington @natikgadzhi @ChristoGrab @alafanechere @octavia-squidington-iii