minor changes to the java CDK test code #35774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Mar 2, 2024
Closed
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
force-pushed
the
stephane/03-02-minor_changes_to_the_java_CDK_test_code
branch
from
b51e1c4
to
28b5097
Compare
stephane-airbyte
force-pushed
the
stephane/03-02-minor_changes_to_the_java_CDK_test_code
branch
7 times, most recently
from
720fd9e
to
6bf2e0e
Compare
stephane-airbyte
force-pushed
the
stephane/03-02-minor_changes_to_the_java_CDK_test_code
branch
from
6bf2e0e
to
75c7f97
Compare
postamar
reviewed
Mar 4, 2024
...e-cdk/core/src/testFixtures/java/io/airbyte/cdk/extensions/LoggingInvocationInterceptor.java
Outdated
Show resolved
Hide resolved
postamar
reviewed
Mar 4, 2024
...e-cdk/core/src/testFixtures/java/io/airbyte/cdk/extensions/LoggingInvocationInterceptor.java
Show resolved
Hide resolved
postamar
reviewed
Mar 4, 2024
| @@ -157,8 +167,8 @@ public UnexpectedRecord(String streamName, String unexpectedValue) { | |||
|
|
|||
There was a problem hiding this comment.
[Re: line 163]
consider taking the opportunity of turning these into records, they stringify nicer
See this comment inline on Graphite.
consider taking the opportunity of turning these into records, they stringify nicer
See this comment inline on Graphite.
postamar
reviewed
Mar 4, 2024
| for (final TestDataHolder test : testDataHolders) { | ||
| database.query(ctx -> { | ||
| ctx.fetch(test.getCreateSqlQuery()); | ||
| LOGGER.debug("Table " + test.getNameWithTestPrefix() + " is created."); | ||
| LOGGER.info("Table {} is created.", test.getNameWithTestPrefix()); |
There was a problem hiding this comment.
Suppose the table creation actually fails, will this log message be emitted anyway? Probably not, but worth double checking, in case jooq is lazy (dunno if it is)
postamar
approved these changes
Mar 4, 2024
stephane-airbyte
force-pushed
the
stephane/03-02-minor_changes_to_the_java_CDK_test_code
branch
from
75c7f97
to
8b32b67
Compare
stephane-airbyte
force-pushed
the
stephane/03-02-minor_changes_to_the_java_CDK_test_code
branch
2 times, most recently
from
e9439f0
to
1adba2a
Compare
stephane-airbyte
force-pushed
the
stephane/03-02-minor_changes_to_the_java_CDK_test_code
branch
from
1adba2a
to
152c690
Compare
|
/publish-java-cdk
|
stephane-airbyte
deleted the
stephane/03-02-minor_changes_to_the_java_CDK_test_code
branch
xiaohansong
pushed a commit
that referenced
this pull request
Mar 7, 2024
--- <details open="true"><summary>Generated summary (powered by <a href="https://app.graphite.dev">Graphite</a>)</summary> > ## TL;DR > This pull request adds logging for non-public JUnit methods and updates test methods to be public. > > ## What changed > - Added logging for non-public JUnit methods in `LoggingInvocationInterceptor.java`. > - Updated test methods to be public in `CdcSourceTest.java`. > - Updated logging message in `DefaultAirbyteSource.java`. > > ## How to test > No specific testing instructions provided. > > ## Why make this change > - To improve visibility and debugging by logging non-public JUnit methods. > - To ensure consistency and best practices by making test methods public. </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated summary (powered by Graphite)